Switch from PrintTo to operator<< for platform printers

Switch from PrintTo to operator<< for platform printers

This patch adds operator<< on all platform datatypes which forwards
to the toString() functions added in crbug.com/632096.

For example, to print the value of a LayoutRect:
    LayoutRect overflowRect(1, 2, 3, 4);
    LOG(INFO) << "overflow: " << overflowRect;
Which prints:
    overflow: "1,2 3x4"

gtests will automatically call the operator<< functions so the PrintTo
functions have been removed. operator<< is rare but follows
https://google.github.io/styleguide/cppguide.html.

Binary size difference on linux with is_official_build: 17808b :(

BUG=632096

[pdr., 2016-08-23 05:10:11]

Description was changed from

==========
Switch from PrintTo to operator<< for platform printers

This patch adds operator<< on all platform datatypes which forwards
to the toString() functions added in crbug.com/632096.

For example, to print the value of a LayoutRect:
    LayoutRect overflowRect(1, 2, 3, 4);
    LOG(INFO) << "overflow: " << overflowRect;
Which prints:
    overflow: "1,2 3x4"

gtests will automatically call the operator<< functions so the PrintTo
functions have been removed. operator<< is rare but follows
https://google.github.io/styleguide/cppguide.html.

Binary size difference on linux with is_official_build: TBD

BUG=632096
==========

to

==========
Switch from PrintTo to operator<< for platform printers

This patch adds operator<< on all platform datatypes which forwards
to the toString() functions added in crbug.com/632096.

For example, to print the value of a LayoutRect:
    LayoutRect overflowRect(1, 2, 3, 4);
    LOG(INFO) << "overflow: " << overflowRect;
Which prints:
    overflow: "1,2 3x4"

gtests will automatically call the operator<< functions so the PrintTo
functions have been removed. operator<< is rare but follows
https://google.github.io/styleguide/cppguide.html.

Binary size difference on linux with is_official_build: 17808b :(

BUG=632096
==========

[pdr., 2016-08-24 18:47:36]

pdr@chromium.org changed reviewers:
+ chrishtr@chromium.org, danakj@chromium.org

[pdr., 2016-08-24 18:48:02]

Unfortunately this had a huge effect on binary size :(

Do either of you know why?

[danakj, 2016-08-24 19:01:37]

On Wed, Aug 24, 2016 at 11:48 AM, <pdr@chromium.org> wrote:

> Reviewers: chrishtr, danakj
> CL: https://codereview.chromium.org/2267183003/
>
> Message:
> Unfortunately this had a huge effect on binary size :(
>
> Do either of you know why?
>

Newp. But http://arstechnica.com/civis/viewtopic.php?f=20&t=179042 says: "what
we get in return is a '#include <iostream>' that doubles your compile times
and adds 100K to your binary size" due to horrible templates.


>
> Description:
> Switch from PrintTo to operator<< for platform printers
>
> This patch adds operator<< on all platform datatypes which forwards
> to the toString() functions added in crbug.com/632096.
>
> For example, to print the value of a LayoutRect:
> LayoutRect overflowRect(1, 2, 3, 4);
> LOG(INFO) << "overflow: " << overflowRect;
> Which prints:
> overflow: "1,2 3x4"
>
> gtests will automatically call the operator<< functions so the PrintTo
> functions have been removed. operator<< is rare but follows
> https://google.github.io/styleguide/cppguide.html.
>
> Binary size difference on linux with is_official_build: 17808b :(
>
> BUG=632096
>
> Base URL: https://chromium.googlesource.com/chromium/src.git@master
>
> Affected files (+120, -303 lines):
> M third_party/WebKit/Source/platform/blink_platform.gypi
> M third_party/WebKit/Source/platform/geometry/DoublePoint.h
> M third_party/WebKit/Source/platform/geometry/DoublePoint.cpp
> M third_party/WebKit/Source/platform/geometry/DoubleRect.h
> M third_party/WebKit/Source/platform/geometry/DoubleRect.cpp
> M third_party/WebKit/Source/platform/geometry/DoubleSize.h
> M third_party/WebKit/Source/platform/geometry/DoubleSize.cpp
> M third_party/WebKit/Source/platform/geometry/FloatBox.h
> M third_party/WebKit/Source/platform/geometry/FloatBox.cpp
> M third_party/WebKit/Source/platform/geometry/FloatPoint.h
> M third_party/WebKit/Source/platform/geometry/FloatPoint.cpp
> M third_party/WebKit/Source/platform/geometry/FloatPoint3D.h
> M third_party/WebKit/Source/platform/geometry/FloatPoint3D.cpp
> M third_party/WebKit/Source/platform/geometry/FloatQuad.h
> M third_party/WebKit/Source/platform/geometry/FloatQuad.cpp
> M third_party/WebKit/Source/platform/geometry/FloatRect.h
> M third_party/WebKit/Source/platform/geometry/FloatRect.cpp
> M third_party/WebKit/Source/platform/geometry/FloatRoundedRect.h
> M third_party/WebKit/Source/platform/geometry/FloatRoundedRect.cpp
> M third_party/WebKit/Source/platform/geometry/FloatSize.h
> M third_party/WebKit/Source/platform/geometry/FloatSize.cpp
> M third_party/WebKit/Source/platform/geometry/IntPoint.h
> M third_party/WebKit/Source/platform/geometry/IntPoint.cpp
> M third_party/WebKit/Source/platform/geometry/IntRect.h
> M third_party/WebKit/Source/platform/geometry/IntRect.cpp
> M third_party/WebKit/Source/platform/geometry/IntSize.h
> M third_party/WebKit/Source/platform/geometry/IntSize.cpp
> M third_party/WebKit/Source/platform/geometry/LayoutPoint.h
> M third_party/WebKit/Source/platform/geometry/LayoutPoint.cpp
> M third_party/WebKit/Source/platform/geometry/LayoutRect.h
> M third_party/WebKit/Source/platform/geometry/LayoutRect.cpp
> M third_party/WebKit/Source/platform/geometry/LayoutSize.h
> M third_party/WebKit/Source/platform/geometry/LayoutSize.cpp
> D third_party/WebKit/Source/platform/testing/GeometryPrinters.h
> D third_party/WebKit/Source/platform/testing/GeometryPrinters.cpp
> M third_party/WebKit/Source/platform/testing/PaintPrinters.cpp
> M third_party/WebKit/Source/platform/testing/PictureMatchers.cpp
> D third_party/WebKit/Source/platform/testing/TransformPrinters.h
> D third_party/WebKit/Source/platform/testing/TransformPrinters.cpp
> M third_party/WebKit/Source/platform/transforms/AffineTransform.h
> M third_party/WebKit/Source/platform/transforms/AffineTransform.cpp
> M third_party/WebKit/Source/platform/transforms/TransformationMatrix.h
> M third_party/WebKit/Source/platform/transforms/TransformationMatrix.cpp
>
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[danakj, 2016-08-24 19:01:54]

On Wed, Aug 24, 2016 at 11:53 AM, <danakj@chromium.org> wrote:

> On Wed, Aug 24, 2016 at 11:48 AM, <pdr@chromium.org> wrote:
>
>> Reviewers: chrishtr, danakj
>> CL: https://codereview.chromium.org/2267183003/
>>
>> Message:
>> Unfortunately this had a huge effect on binary size :(
>>
>> Do either of you know why?
>>
>
> Newp. But http://arstechnica.com/civis/viewtopic.php?f=20&t=179042 says:
"what
> we get in return is a '#include <iostream>' that doubles your compile times
> and adds 100K to your binary size" due to horrible templates.
>

And https://lists.webkit.org/pipermail/webkit-dev/2012-July/021525.html
says:

"Now consider the stream form:

thingy << "foo " << a << " bar " << someWeirdNonsenseToEnableHex << b << "
baz " << c << endl;

This is 8 procedure calls and three string constants. This code will be
somewhere around 8 times fatter. Hence, you will be less likely to want to
enable such debug statements in release builds both due to fears concerning
unnecessary increases in binary size, and unnecessary increases in compile
times."

But I don't know that it explains operator<<(std::string) vs
operator<<(IntRect).


>
>
>>
>> Description:
>> Switch from PrintTo to operator<< for platform printers
>>
>> This patch adds operator<< on all platform datatypes which forwards
>> to the toString() functions added in crbug.com/632096.
>>
>> For example, to print the value of a LayoutRect:
>> LayoutRect overflowRect(1, 2, 3, 4);
>> LOG(INFO) << "overflow: " << overflowRect;
>> Which prints:
>> overflow: "1,2 3x4"
>>
>> gtests will automatically call the operator<< functions so the PrintTo
>> functions have been removed. operator<< is rare but follows
>> https://google.github.io/styleguide/cppguide.html.
>>
>> Binary size difference on linux with is_official_build: 17808b :(
>>
>> BUG=632096
>>
>> Base URL: https://chromium.googlesource.com/chromium/src.git@master
>>
>> Affected files (+120, -303 lines):
>> M third_party/WebKit/Source/platform/blink_platform.gypi
>> M third_party/WebKit/Source/platform/geometry/DoublePoint.h
>> M third_party/WebKit/Source/platform/geometry/DoublePoint.cpp
>> M third_party/WebKit/Source/platform/geometry/DoubleRect.h
>> M third_party/WebKit/Source/platform/geometry/DoubleRect.cpp
>> M third_party/WebKit/Source/platform/geometry/DoubleSize.h
>> M third_party/WebKit/Source/platform/geometry/DoubleSize.cpp
>> M third_party/WebKit/Source/platform/geometry/FloatBox.h
>> M third_party/WebKit/Source/platform/geometry/FloatBox.cpp
>> M third_party/WebKit/Source/platform/geometry/FloatPoint.h
>> M third_party/WebKit/Source/platform/geometry/FloatPoint.cpp
>> M third_party/WebKit/Source/platform/geometry/FloatPoint3D.h
>> M third_party/WebKit/Source/platform/geometry/FloatPoint3D.cpp
>> M third_party/WebKit/Source/platform/geometry/FloatQuad.h
>> M third_party/WebKit/Source/platform/geometry/FloatQuad.cpp
>> M third_party/WebKit/Source/platform/geometry/FloatRect.h
>> M third_party/WebKit/Source/platform/geometry/FloatRect.cpp
>> M third_party/WebKit/Source/platform/geometry/FloatRoundedRect.h
>> M third_party/WebKit/Source/platform/geometry/FloatRoundedRect.cpp
>> M third_party/WebKit/Source/platform/geometry/FloatSize.h
>> M third_party/WebKit/Source/platform/geometry/FloatSize.cpp
>> M third_party/WebKit/Source/platform/geometry/IntPoint.h
>> M third_party/WebKit/Source/platform/geometry/IntPoint.cpp
>> M third_party/WebKit/Source/platform/geometry/IntRect.h
>> M third_party/WebKit/Source/platform/geometry/IntRect.cpp
>> M third_party/WebKit/Source/platform/geometry/IntSize.h
>> M third_party/WebKit/Source/platform/geometry/IntSize.cpp
>> M third_party/WebKit/Source/platform/geometry/LayoutPoint.h
>> M third_party/WebKit/Source/platform/geometry/LayoutPoint.cpp
>> M third_party/WebKit/Source/platform/geometry/LayoutRect.h
>> M third_party/WebKit/Source/platform/geometry/LayoutRect.cpp
>> M third_party/WebKit/Source/platform/geometry/LayoutSize.h
>> M third_party/WebKit/Source/platform/geometry/LayoutSize.cpp
>> D third_party/WebKit/Source/platform/testing/GeometryPrinters.h
>> D third_party/WebKit/Source/platform/testing/GeometryPrinters.cpp
>> M third_party/WebKit/Source/platform/testing/PaintPrinters.cpp
>> M third_party/WebKit/Source/platform/testing/PictureMatchers.cpp
>> D third_party/WebKit/Source/platform/testing/TransformPrinters.h
>> D third_party/WebKit/Source/platform/testing/TransformPrinters.cpp
>> M third_party/WebKit/Source/platform/transforms/AffineTransform.h
>> M third_party/WebKit/Source/platform/transforms/AffineTransform.cpp
>> M third_party/WebKit/Source/platform/transforms/TransformationMatrix.h
>> M third_party/WebKit/Source/platform/transforms/TransformationMatrix.cpp
>>
>>
>>
>

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[danakj, 2016-08-24 19:01:59]

On Wed, Aug 24, 2016 at 11:48 AM, <pdr@chromium.org> wrote:

> Reviewers: chrishtr, danakj
> CL: https://codereview.chromium.org/2267183003/
>
> Message:
> Unfortunately this had a huge effect on binary size :(
>
> Do either of you know why?
>

Newp. But http://arstechnica.com/civis/viewtopic.php?f=20&t=179042 says: "what
we get in return is a '#include <iostream>' that doubles your compile times
and adds 100K to your binary size" due to horrible templates.


>
> Description:
> Switch from PrintTo to operator<< for platform printers
>
> This patch adds operator<< on all platform datatypes which forwards
> to the toString() functions added in crbug.com/632096.
>
> For example, to print the value of a LayoutRect:
> LayoutRect overflowRect(1, 2, 3, 4);
> LOG(INFO) << "overflow: " << overflowRect;
> Which prints:
> overflow: "1,2 3x4"
>
> gtests will automatically call the operator<< functions so the PrintTo
> functions have been removed. operator<< is rare but follows
> https://google.github.io/styleguide/cppguide.html.
>
> Binary size difference on linux with is_official_build: 17808b :(
>
> BUG=632096
>
> Base URL: https://chromium.googlesource.com/chromium/src.git@master
>
> Affected files (+120, -303 lines):
> M third_party/WebKit/Source/platform/blink_platform.gypi
> M third_party/WebKit/Source/platform/geometry/DoublePoint.h
> M third_party/WebKit/Source/platform/geometry/DoublePoint.cpp
> M third_party/WebKit/Source/platform/geometry/DoubleRect.h
> M third_party/WebKit/Source/platform/geometry/DoubleRect.cpp
> M third_party/WebKit/Source/platform/geometry/DoubleSize.h
> M third_party/WebKit/Source/platform/geometry/DoubleSize.cpp
> M third_party/WebKit/Source/platform/geometry/FloatBox.h
> M third_party/WebKit/Source/platform/geometry/FloatBox.cpp
> M third_party/WebKit/Source/platform/geometry/FloatPoint.h
> M third_party/WebKit/Source/platform/geometry/FloatPoint.cpp
> M third_party/WebKit/Source/platform/geometry/FloatPoint3D.h
> M third_party/WebKit/Source/platform/geometry/FloatPoint3D.cpp
> M third_party/WebKit/Source/platform/geometry/FloatQuad.h
> M third_party/WebKit/Source/platform/geometry/FloatQuad.cpp
> M third_party/WebKit/Source/platform/geometry/FloatRect.h
> M third_party/WebKit/Source/platform/geometry/FloatRect.cpp
> M third_party/WebKit/Source/platform/geometry/FloatRoundedRect.h
> M third_party/WebKit/Source/platform/geometry/FloatRoundedRect.cpp
> M third_party/WebKit/Source/platform/geometry/FloatSize.h
> M third_party/WebKit/Source/platform/geometry/FloatSize.cpp
> M third_party/WebKit/Source/platform/geometry/IntPoint.h
> M third_party/WebKit/Source/platform/geometry/IntPoint.cpp
> M third_party/WebKit/Source/platform/geometry/IntRect.h
> M third_party/WebKit/Source/platform/geometry/IntRect.cpp
> M third_party/WebKit/Source/platform/geometry/IntSize.h
> M third_party/WebKit/Source/platform/geometry/IntSize.cpp
> M third_party/WebKit/Source/platform/geometry/LayoutPoint.h
> M third_party/WebKit/Source/platform/geometry/LayoutPoint.cpp
> M third_party/WebKit/Source/platform/geometry/LayoutRect.h
> M third_party/WebKit/Source/platform/geometry/LayoutRect.cpp
> M third_party/WebKit/Source/platform/geometry/LayoutSize.h
> M third_party/WebKit/Source/platform/geometry/LayoutSize.cpp
> D third_party/WebKit/Source/platform/testing/GeometryPrinters.h
> D third_party/WebKit/Source/platform/testing/GeometryPrinters.cpp
> M third_party/WebKit/Source/platform/testing/PaintPrinters.cpp
> M third_party/WebKit/Source/platform/testing/PictureMatchers.cpp
> D third_party/WebKit/Source/platform/testing/TransformPrinters.h
> D third_party/WebKit/Source/platform/testing/TransformPrinters.cpp
> M third_party/WebKit/Source/platform/transforms/AffineTransform.h
> M third_party/WebKit/Source/platform/transforms/AffineTransform.cpp
> M third_party/WebKit/Source/platform/transforms/TransformationMatrix.h
> M third_party/WebKit/Source/platform/transforms/TransformationMatrix.cpp
>
>
>

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[danakj, 2016-08-24 19:02:31]

On Wed, Aug 24, 2016 at 11:53 AM, <danakj@chromium.org> wrote:

> On Wed, Aug 24, 2016 at 11:48 AM, <pdr@chromium.org> wrote:
>
>> Reviewers: chrishtr, danakj
>> CL: https://codereview.chromium.org/2267183003/
>>
>> Message:
>> Unfortunately this had a huge effect on binary size :(
>>
>> Do either of you know why?
>>
>
> Newp. But http://arstechnica.com/civis/viewtopic.php?f=20&t=179042 says:
"what
> we get in return is a '#include <iostream>' that doubles your compile times
> and adds 100K to your binary size" due to horrible templates.
>

And https://lists.webkit.org/pipermail/webkit-dev/2012-July/021525.html
says:

"Now consider the stream form:

thingy << "foo " << a << " bar " << someWeirdNonsenseToEnableHex << b << "
baz " << c << endl;

This is 8 procedure calls and three string constants. This code will be
somewhere around 8 times fatter. Hence, you will be less likely to want to
enable such debug statements in release builds both due to fears concerning
unnecessary increases in binary size, and unnecessary increases in compile
times."

But I don't know that it explains operator<<(std::string) vs
operator<<(IntRect).


>
>
>>
>> Description:
>> Switch from PrintTo to operator<< for platform printers
>>
>> This patch adds operator<< on all platform datatypes which forwards
>> to the toString() functions added in crbug.com/632096.
>>
>> For example, to print the value of a LayoutRect:
>> LayoutRect overflowRect(1, 2, 3, 4);
>> LOG(INFO) << "overflow: " << overflowRect;
>> Which prints:
>> overflow: "1,2 3x4"
>>
>> gtests will automatically call the operator<< functions so the PrintTo
>> functions have been removed. operator<< is rare but follows
>> https://google.github.io/styleguide/cppguide.html.
>>
>> Binary size difference on linux with is_official_build: 17808b :(
>>
>> BUG=632096
>>
>> Base URL: https://chromium.googlesource.com/chromium/src.git@master
>>
>> Affected files (+120, -303 lines):
>> M third_party/WebKit/Source/platform/blink_platform.gypi
>> M third_party/WebKit/Source/platform/geometry/DoublePoint.h
>> M third_party/WebKit/Source/platform/geometry/DoublePoint.cpp
>> M third_party/WebKit/Source/platform/geometry/DoubleRect.h
>> M third_party/WebKit/Source/platform/geometry/DoubleRect.cpp
>> M third_party/WebKit/Source/platform/geometry/DoubleSize.h
>> M third_party/WebKit/Source/platform/geometry/DoubleSize.cpp
>> M third_party/WebKit/Source/platform/geometry/FloatBox.h
>> M third_party/WebKit/Source/platform/geometry/FloatBox.cpp
>> M third_party/WebKit/Source/platform/geometry/FloatPoint.h
>> M third_party/WebKit/Source/platform/geometry/FloatPoint.cpp
>> M third_party/WebKit/Source/platform/geometry/FloatPoint3D.h
>> M third_party/WebKit/Source/platform/geometry/FloatPoint3D.cpp
>> M third_party/WebKit/Source/platform/geometry/FloatQuad.h
>> M third_party/WebKit/Source/platform/geometry/FloatQuad.cpp
>> M third_party/WebKit/Source/platform/geometry/FloatRect.h
>> M third_party/WebKit/Source/platform/geometry/FloatRect.cpp
>> M third_party/WebKit/Source/platform/geometry/FloatRoundedRect.h
>> M third_party/WebKit/Source/platform/geometry/FloatRoundedRect.cpp
>> M third_party/WebKit/Source/platform/geometry/FloatSize.h
>> M third_party/WebKit/Source/platform/geometry/FloatSize.cpp
>> M third_party/WebKit/Source/platform/geometry/IntPoint.h
>> M third_party/WebKit/Source/platform/geometry/IntPoint.cpp
>> M third_party/WebKit/Source/platform/geometry/IntRect.h
>> M third_party/WebKit/Source/platform/geometry/IntRect.cpp
>> M third_party/WebKit/Source/platform/geometry/IntSize.h
>> M third_party/WebKit/Source/platform/geometry/IntSize.cpp
>> M third_party/WebKit/Source/platform/geometry/LayoutPoint.h
>> M third_party/WebKit/Source/platform/geometry/LayoutPoint.cpp
>> M third_party/WebKit/Source/platform/geometry/LayoutRect.h
>> M third_party/WebKit/Source/platform/geometry/LayoutRect.cpp
>> M third_party/WebKit/Source/platform/geometry/LayoutSize.h
>> M third_party/WebKit/Source/platform/geometry/LayoutSize.cpp
>> D third_party/WebKit/Source/platform/testing/GeometryPrinters.h
>> D third_party/WebKit/Source/platform/testing/GeometryPrinters.cpp
>> M third_party/WebKit/Source/platform/testing/PaintPrinters.cpp
>> M third_party/WebKit/Source/platform/testing/PictureMatchers.cpp
>> D third_party/WebKit/Source/platform/testing/TransformPrinters.h
>> D third_party/WebKit/Source/platform/testing/TransformPrinters.cpp
>> M third_party/WebKit/Source/platform/transforms/AffineTransform.h
>> M third_party/WebKit/Source/platform/transforms/AffineTransform.cpp
>> M third_party/WebKit/Source/platform/transforms/TransformationMatrix.h
>> M third_party/WebKit/Source/platform/transforms/TransformationMatrix.cpp
>>
>>
>>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.