third_party/WebKit/Source/platform/testing/PaintPrinters.cpp - Issue 2267183003: Switch from PrintTo to operator<< for platform printers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/testing/PaintPrinters.cpp

Issue 2267183003: Switch from PrintTo to operator<< for platform printers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/testing/GeometryPrinters.cpp ('k') | third_party/WebKit/Source/platform/testing/PictureMatchers.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/testing/PaintPrinters.cpp

diff --git a/third_party/WebKit/Source/platform/testing/PaintPrinters.cpp b/third_party/WebKit/Source/platform/testing/PaintPrinters.cpp

index 8cd0db3ff0ce751ac912a7db9e59b467b8929bcf..496ee78051b57f1595de0efd90605ebe7c0a40b6 100644

--- a/third_party/WebKit/Source/platform/testing/PaintPrinters.cpp

+++ b/third_party/WebKit/Source/platform/testing/PaintPrinters.cpp

@@ -32,8 +32,7 @@ static void PrintPointer(const void* ptr, std::ostream& os)

void PrintTo(const ClipPaintPropertyNode& node, std::ostream* os)

{

- *os << "ClipPaintPropertyNode(clip=";

- PrintTo(node.clipRect(), os);

+ *os << "ClipPaintPropertyNode(clip=" << node.clipRect();

*os << ", localTransformSpace=";

PrintPointer(node.localTransformSpace(), *os);

*os << ", parent=";

@@ -59,9 +58,7 @@ void PrintTo(const PaintChunk& chunk, std::ostream* os)

}

*os << ", props=";

PrintTo(chunk.properties, os);

- *os << ", bounds=";

- PrintTo(chunk.bounds, os);

- *os << ", knownToBeOpaque=" << chunk.knownToBeOpaque << ")";

+ *os << ", bounds=" << chunk.bounds << ", knownToBeOpaque=" << chunk.knownToBeOpaque << ")";

}

void PrintTo(const PaintChunkProperties& properties, std::ostream* os)

@@ -99,11 +96,8 @@ void PrintTo(const PaintChunkProperties& properties, std::ostream* os)

void PrintTo(const TransformPaintPropertyNode& transformPaintProperty, std::ostream* os)

{

- *os << "TransformPaintPropertyNode(matrix=";

- PrintTo(transformPaintProperty.matrix(), os);

- *os << ", origin=";

- PrintTo(transformPaintProperty.origin(), os);

- *os << ")";

+ *os << "TransformPaintPropertyNode(matrix=" << transformPaintProperty.matrix()

+ << ", origin=" << transformPaintProperty.origin() << ")";

}

void PrintTo(const EffectPaintPropertyNode& effect, std::ostream* os)