ash: Remove unnecessary utility methods from ash::Shelf

ash: Remove unnecessary utility methods from ash::Shelf

IsVisible(), IsShowingMenu() and IsShowingOverflowBubble() are only used by
shelf code and are better handled directly by ShelfWidget.

This is a step toward eliminating ash::Shelf.

BUG=615502
TEST=ash_unittests

Committed: https://crrev.com/9e30e4cfa33d319c7bd8e2b27f0a7e9db93a78e8
Cr-Commit-Position: refs/heads/master@{#413757}

[James Cook, 2016-08-22 23:37:46]

Patchset #1 (id:1) has been deleted

[James Cook, 2016-08-22 23:37:56]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[James Cook, 2016-08-22 23:38:15]

jamescook@chromium.org changed reviewers:
+ msw@chromium.org

[James Cook, 2016-08-22 23:38:16]

msw, please take a look.

[commit-bot: I haz the power, 2016-08-22 23:38:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msw, 2016-08-22 23:45:30]

lgtm with an optional nit

https://codereview.chromium.org/2267183002/diff/20001/ash/shelf/shelf_widget.h
File ash/shelf/shelf_widget.h (right):

https://codereview.chromium.org/2267183002/diff/20001/ash/shelf/shelf_widget....
ash/shelf/shelf_widget.h:76: bool IsShowingMenu() const;
nit: rename IsShowingContextMenu and remove comment.

[commit-bot: I haz the power, 2016-08-23 00:27:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-23 00:27:50]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[James Cook, 2016-08-23 15:37:16]

The CQ bit was checked by jamescook@chromium.org

[James Cook, 2016-08-23 15:37:16]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org
Link to the patchset: https://codereview.chromium.org/2267183002/#ps60001
(title: "nits")

[commit-bot: I haz the power, 2016-08-23 15:37:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-23 16:28:09]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-08-23 16:29:35]

Description was changed from

==========
ash: Remove unnecessary utility methods from ash::Shelf

IsVisible(), IsShowingMenu() and IsShowingOverflowBubble() are only used by
shelf code and are better handled directly by ShelfWidget.

This is a step toward eliminating ash::Shelf.

BUG=615502
TEST=ash_unittests
==========

to

==========
ash: Remove unnecessary utility methods from ash::Shelf

IsVisible(), IsShowingMenu() and IsShowingOverflowBubble() are only used by
shelf code and are better handled directly by ShelfWidget.

This is a step toward eliminating ash::Shelf.

BUG=615502
TEST=ash_unittests

Committed: https://crrev.com/9e30e4cfa33d319c7bd8e2b27f0a7e9db93a78e8
Cr-Commit-Position: refs/heads/master@{#413757}
==========

[commit-bot: I haz the power, 2016-08-23 16:29:36]

Patchset 3 (id:??) landed as
https://crrev.com/9e30e4cfa33d319c7bd8e2b27f0a7e9db93a78e8
Cr-Commit-Position: refs/heads/master@{#413757}