Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Unified Diff: ash/shelf/shelf_unittest.cc

Issue 2267183002: ash: Remove unnecessary utility methods from ash::Shelf (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nits Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/shelf/shelf_layout_manager.cc ('k') | ash/shelf/shelf_widget.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/shelf/shelf_unittest.cc
diff --git a/ash/shelf/shelf_unittest.cc b/ash/shelf/shelf_unittest.cc
index 686cc341caa6224e3ccae5364409ca9fb9da35b2..389593fcd100b9ab9cace05f233a707a630e9438 100644
--- a/ash/shelf/shelf_unittest.cc
+++ b/ash/shelf/shelf_unittest.cc
@@ -108,6 +108,7 @@ TEST_F(ShelfTest, CheckHoverAfterMenu) {
}
TEST_F(ShelfTest, ShowOverflowBubble) {
+ ShelfWidget* shelf_widget = shelf()->shelf_widget();
ShelfID first_item_id = shelf_model()->next_id();
// Add platform app button until overflow.
@@ -124,14 +125,14 @@ TEST_F(ShelfTest, ShowOverflowBubble) {
// Shows overflow bubble.
test_api()->ShowOverflowBubble();
- EXPECT_TRUE(shelf()->IsShowingOverflowBubble());
+ EXPECT_TRUE(shelf_widget->IsShowingOverflowBubble());
// Removes the first item in main shelf view.
shelf_model()->RemoveItemAt(shelf_model()->ItemIndexByID(first_item_id));
// Waits for all transitions to finish and there should be no crash.
test_api()->RunMessageLoopUntilAnimationsDone();
- EXPECT_FALSE(shelf()->IsShowingOverflowBubble());
+ EXPECT_FALSE(shelf_widget->IsShowingOverflowBubble());
}
} // namespace ash
« no previous file with comments | « ash/shelf/shelf_layout_manager.cc ('k') | ash/shelf/shelf_widget.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698