Re-enable program memory cache for Adreno 4/5xx

Re-enable program memory cache for Adreno 4/5xx

The program cache was disabled on Adreno 4/5xx due to crashes.

I'm hoping that this issue was caused by invalidations/issues with the
on-disk program cache, possibly with driver updates or other issues.

To test this, I'm re-enabling the in-memory portion of the cache
only. The cached objects will not outlive the GPU process.

I've also confirmed that the related Adreno 3xx bug, crbug.com/510673,
does not impact the Adreno 400 (and I'm guessing 500, but will track
down a device to double check).

We should watch crash rates for gfx::GLApiBase::glProgramBinaryFn to
make sure this change doesn't re-introduce these crashes.

BUG=598060, 486117
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/30bcb92ee59a6778c4025081d7da82d2af8cccc2
Cr-Commit-Position: refs/heads/master@{#414490}

[ericrk, 2016-08-23 00:16:26]

Description was changed from

==========
Re-enable program memory cache for Adreno 4/5xx

The program cache was disabled on Adreno 4/5xx due to crashes.

I'm hoping that this issue was caused by invalidations/issues with the
on-disk program cache, possibly with driver updates or other issues.

To test this, I'm re-enabling the in-memory portion of the cache
only. The cached objects will not outlive the GPU process.

I've also confirmed that the related Adreno 3xx bug, crbug.com/510673,
does not impact the Adreno 400 (and I'm guessing 500, but will track
down a device to double check).

We should watch crash rates for gfx::GLApiBase::glProgramBinaryFn to
make sure this change doesn't re-introduce these crashes.

BUG=598060, 486117
==========

to

==========
Re-enable program memory cache for Adreno 4/5xx

The program cache was disabled on Adreno 4/5xx due to crashes.

I'm hoping that this issue was caused by invalidations/issues with the
on-disk program cache, possibly with driver updates or other issues.

To test this, I'm re-enabling the in-memory portion of the cache
only. The cached objects will not outlive the GPU process.

I've also confirmed that the related Adreno 3xx bug, crbug.com/510673,
does not impact the Adreno 400 (and I'm guessing 500, but will track
down a device to double check).

We should watch crash rates for gfx::GLApiBase::glProgramBinaryFn to
make sure this change doesn't re-introduce these crashes.

BUG=598060, 486117
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[ericrk, 2016-08-23 00:16:27]

Description was changed from

==========
Re-enable program memory cache for Adreno 4/5xx

The program cache was disabled on Adreno 4/5xx due to crashes.

I'm hoping that this issue was caused by invalidations/issues with the
on-disk program cache, possibly with driver updates or other issues.

To test this, I'm re-enabling the in-memory portion of the cache
only. The cached objects will not outlive the GPU process.

I've also confirmed that the related Adreno 3xx bug, crbug.com/510673,
does not impact the Adreno 400 (and I'm guessing 500, but will track
down a device to double check).

We should watch crash rates for gfx::GLApiBase::glProgramBinaryFn to
make sure this change doesn't re-introduce these crashes.

BUG=598060, 486117
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Re-enable program memory cache for Adreno 4/5xx

The program cache was disabled on Adreno 4/5xx due to crashes.

I'm hoping that this issue was caused by invalidations/issues with the
on-disk program cache, possibly with driver updates or other issues.

To test this, I'm re-enabling the in-memory portion of the cache
only. The cached objects will not outlive the GPU process.

I've also confirmed that the related Adreno 3xx bug, crbug.com/510673,
does not impact the Adreno 400 (and I'm guessing 500, but will track
down a device to double check).

We should watch crash rates for gfx::GLApiBase::glProgramBinaryFn to
make sure this change doesn't re-introduce these crashes.

BUG=598060, 486117
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[ericrk, 2016-08-23 00:19:07]

Patchset #2 (id:20001) has been deleted

[ericrk, 2016-08-23 00:19:26]

Patchset #1 (id:1) has been deleted

[ericrk, 2016-08-23 00:20:33]

ericrk@chromium.org changed reviewers:
+ sievers@chromium.org

[no sievers, 2016-08-23 21:28:19]

lgtm

https://codereview.chromium.org/2267163003/diff/40001/gpu/config/gpu_driver_b...
File gpu/config/gpu_driver_bug_list_json.cc (right):

https://codereview.chromium.org/2267163003/diff/40001/gpu/config/gpu_driver_b...
gpu/config/gpu_driver_bug_list_json.cc:22: "version": "8.83",
bump the version

[ericrk, 2016-08-25 00:31:26]

https://codereview.chromium.org/2267163003/diff/40001/gpu/config/gpu_driver_b...
File gpu/config/gpu_driver_bug_list_json.cc (right):

https://codereview.chromium.org/2267163003/diff/40001/gpu/config/gpu_driver_b...
gpu/config/gpu_driver_bug_list_json.cc:22: "version": "8.83",
On 2016/08/23 21:28:18, sievers wrote:
> bump the version

Done.

[ericrk, 2016-08-25 00:31:37]

The CQ bit was checked by ericrk@chromium.org

[ericrk, 2016-08-25 00:31:37]

The patchset sent to the CQ was uploaded after l-g-t-m from sievers@chromium.org
Link to the patchset: https://codereview.chromium.org/2267163003/#ps60001
(title: "bump the version")

[commit-bot: I haz the power, 2016-08-25 00:33:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 00:37:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 00:37:33]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[ericrk, 2016-08-25 17:43:11]

The CQ bit was checked by ericrk@chromium.org

[ericrk, 2016-08-25 17:43:11]

The patchset sent to the CQ was uploaded after l-g-t-m from sievers@chromium.org
Link to the patchset: https://codereview.chromium.org/2267163003/#ps80001
(title: "rebase")

[commit-bot: I haz the power, 2016-08-25 17:43:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 18:47:53]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2016-08-25 18:49:57]

Description was changed from

==========
Re-enable program memory cache for Adreno 4/5xx

The program cache was disabled on Adreno 4/5xx due to crashes.

I'm hoping that this issue was caused by invalidations/issues with the
on-disk program cache, possibly with driver updates or other issues.

To test this, I'm re-enabling the in-memory portion of the cache
only. The cached objects will not outlive the GPU process.

I've also confirmed that the related Adreno 3xx bug, crbug.com/510673,
does not impact the Adreno 400 (and I'm guessing 500, but will track
down a device to double check).

We should watch crash rates for gfx::GLApiBase::glProgramBinaryFn to
make sure this change doesn't re-introduce these crashes.

BUG=598060, 486117
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Re-enable program memory cache for Adreno 4/5xx

The program cache was disabled on Adreno 4/5xx due to crashes.

I'm hoping that this issue was caused by invalidations/issues with the
on-disk program cache, possibly with driver updates or other issues.

To test this, I'm re-enabling the in-memory portion of the cache
only. The cached objects will not outlive the GPU process.

I've also confirmed that the related Adreno 3xx bug, crbug.com/510673,
does not impact the Adreno 400 (and I'm guessing 500, but will track
down a device to double check).

We should watch crash rates for gfx::GLApiBase::glProgramBinaryFn to
make sure this change doesn't re-introduce these crashes.

BUG=598060, 486117
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/30bcb92ee59a6778c4025081d7da82d2af8cccc2
Cr-Commit-Position: refs/heads/master@{#414490}
==========

[commit-bot: I haz the power, 2016-08-25 18:49:59]

Patchset 3 (id:??) landed as
https://crrev.com/30bcb92ee59a6778c4025081d7da82d2af8cccc2
Cr-Commit-Position: refs/heads/master@{#414490}