Scale Rect Origins Using the Specified HWND's Display

Scale Rect Origins Using the Specified HWND's Display

Previously, the origin and rect sizing were scaled independently, which
meant that the origin could be scaled using one display and the size
could be scaled with another display.

With this change, the origin uses the same display used with the size.

Bonus Fix: GetScreenWinDisplayNearestDIPRect now returns the correct
ScreenWinDisplay. If the display touched the DIP rect, the function
would immediately return when a intersecting display would have been
a better choice.

BUG=636521
Committed: https://crrev.com/9383a8485d22e2f4c3ac1c7405a8f00593c6f1d9
Cr-Commit-Position: refs/heads/master@{#413782}

[robliao, 2016-08-22 21:26:28]

Description was changed from

==========
Scale Rect Origins Using the Specified HWND's Display

Previously, the origin and rect sizing were scaled independently, which
meant that the origin could be scaled using one display and the size
could be scaled with another display.

With this change, the origin uses the same display used with the size.

BUG=636521
==========

to

==========
Scale Rect Origins Using the Specified HWND's Display

Previously, the origin and rect sizing were scaled independently, which
meant that the origin could be scaled using one display and the size
could be scaled with another display.

With this change, the origin uses the same display used with the size.

Bonus Fix: GetScreenWinDisplayNearestDIPRect now returns the correct
ScreenWinDisplay. If the display touched the DIP rect, the function 
would immediately return when a intersecting display would have been
a better choice.

BUG=636521
==========

[robliao, 2016-08-22 21:58:35]

kulshin: Since I can't repro the issue with Chrome spanning two monitors, want
to give this patch a try on your machine?

Thanks!

[robliao, 2016-08-22 21:58:40]

The CQ bit was checked by robliao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-22 21:59:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-22 23:01:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-22 23:01:35]

Dry run: This issue passed the CQ dry run.

[robliao, 2016-08-22 23:02:55]

robliao@chromium.org changed reviewers:
+ oshima@chromium.org

[robliao, 2016-08-22 23:02:55]

oshima: Please review this CL. Thanks!

[Ilya Kulshin, 2016-08-23 00:34:03]

On 2016/08/22 21:58:35, robliao wrote:
> kulshin: Since I can't repro the issue with Chrome spanning two monitors, want
> to give this patch a try on your machine?
> 
> Thanks!

Tried it out, this fixes the bug!

[oshima, 2016-08-23 17:49:59]

lgtm

[robliao, 2016-08-23 17:51:27]

The CQ bit was checked by robliao@chromium.org

[commit-bot: I haz the power, 2016-08-23 17:52:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-23 17:56:44]

Description was changed from

==========
Scale Rect Origins Using the Specified HWND's Display

Previously, the origin and rect sizing were scaled independently, which
meant that the origin could be scaled using one display and the size
could be scaled with another display.

With this change, the origin uses the same display used with the size.

Bonus Fix: GetScreenWinDisplayNearestDIPRect now returns the correct
ScreenWinDisplay. If the display touched the DIP rect, the function 
would immediately return when a intersecting display would have been
a better choice.

BUG=636521
==========

to

==========
Scale Rect Origins Using the Specified HWND's Display

Previously, the origin and rect sizing were scaled independently, which
meant that the origin could be scaled using one display and the size
could be scaled with another display.

With this change, the origin uses the same display used with the size.

Bonus Fix: GetScreenWinDisplayNearestDIPRect now returns the correct
ScreenWinDisplay. If the display touched the DIP rect, the function 
would immediately return when a intersecting display would have been
a better choice.

BUG=636521
==========

[commit-bot: I haz the power, 2016-08-23 17:56:45]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-23 18:00:14]

Description was changed from

==========
Scale Rect Origins Using the Specified HWND's Display

Previously, the origin and rect sizing were scaled independently, which
meant that the origin could be scaled using one display and the size
could be scaled with another display.

With this change, the origin uses the same display used with the size.

Bonus Fix: GetScreenWinDisplayNearestDIPRect now returns the correct
ScreenWinDisplay. If the display touched the DIP rect, the function 
would immediately return when a intersecting display would have been
a better choice.

BUG=636521
==========

to

==========
Scale Rect Origins Using the Specified HWND's Display

Previously, the origin and rect sizing were scaled independently, which
meant that the origin could be scaled using one display and the size
could be scaled with another display.

With this change, the origin uses the same display used with the size.

Bonus Fix: GetScreenWinDisplayNearestDIPRect now returns the correct
ScreenWinDisplay. If the display touched the DIP rect, the function
would immediately return when a intersecting display would have been
a better choice.

BUG=636521

Committed: https://crrev.com/9383a8485d22e2f4c3ac1c7405a8f00593c6f1d9
Cr-Commit-Position: refs/heads/master@{#413782}
==========

[commit-bot: I haz the power, 2016-08-23 18:00:16]

Patchset 1 (id:??) landed as
https://crrev.com/9383a8485d22e2f4c3ac1c7405a8f00593c6f1d9
Cr-Commit-Position: refs/heads/master@{#413782}