Scale Rect Origins Using the Specified HWND's Display

ui/display/win/screen_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/display/win/screen_win.h"
 
 #include <windows.h>
 #include <shellscalingapi.h>
 
 #include <algorithm>
@@ skipping 235 matching lines @@
 }
 
 // static
 gfx::Point ScreenWin::DIPToClientPoint(HWND hwnd, const gfx::Point& dip_point) {
   float scale_factor = GetScaleFactorForHWND(hwnd);
   return ScaleToFlooredPoint(dip_point, scale_factor);
 }
 
 // static
 gfx::Rect ScreenWin::ScreenToDIPRect(HWND hwnd, const gfx::Rect& pixel_bounds) {
-  float scale_factor = hwnd ?
-      GetScaleFactorForHWND(hwnd) :
-      GetScreenWinDisplayVia(
-          &ScreenWin::GetScreenWinDisplayNearestScreenRect, pixel_bounds).
-              display().device_scale_factor();
+  const ScreenWinDisplay screen_win_display = hwnd
+      ? GetScreenWinDisplayVia(&ScreenWin::GetScreenWinDisplayNearestHWND, hwnd)
+      : GetScreenWinDisplayVia(
+            &ScreenWin::GetScreenWinDisplayNearestScreenRect, pixel_bounds);
+  float scale_factor = screen_win_display.display().device_scale_factor();
   gfx::Rect dip_rect = ScaleToEnclosingRect(pixel_bounds, 1.0f / scale_factor);
-  dip_rect.set_origin(ScreenToDIPPoint(pixel_bounds.origin()));
+  const display::Display display = screen_win_display.display();
+  dip_rect.set_origin(ScalePointRelative(
+      screen_win_display.pixel_bounds().origin(),
+      display.bounds().origin(),
+      1.0f / scale_factor,
+      pixel_bounds.origin()));
   return dip_rect;
 }
 
 // static
 gfx::Rect ScreenWin::DIPToScreenRect(HWND hwnd, const gfx::Rect& dip_bounds) {
-  float scale_factor = hwnd ?
-      GetScaleFactorForHWND(hwnd) :
-      GetScreenWinDisplayVia(
-          &ScreenWin::GetScreenWinDisplayNearestDIPRect, dip_bounds).display().
-              device_scale_factor();
+  const ScreenWinDisplay screen_win_display = hwnd
+      ? GetScreenWinDisplayVia(&ScreenWin::GetScreenWinDisplayNearestHWND, hwnd)
+      : GetScreenWinDisplayVia(
+            &ScreenWin::GetScreenWinDisplayNearestDIPRect, dip_bounds);
+  float scale_factor = screen_win_display.display().device_scale_factor();
   gfx::Rect screen_rect = ScaleToEnclosingRect(dip_bounds, scale_factor);
-  screen_rect.set_origin(DIPToScreenPoint(dip_bounds.origin()));
+  const display::Display display = screen_win_display.display();
+  screen_rect.set_origin(ScalePointRelative(
+      display.bounds().origin(),
+      screen_win_display.pixel_bounds().origin(),
+      scale_factor,
+      dip_bounds.origin()));
   return screen_rect;
 }
 
 // static
 gfx::Rect ScreenWin::ClientToDIPRect(HWND hwnd, const gfx::Rect& pixel_bounds) {
   return ScaleToEnclosingRect(pixel_bounds, 1.0f / GetScaleFactorForHWND(hwnd));
 }
 
 // static
 gfx::Rect ScreenWin::DIPToClientRect(HWND hwnd, const gfx::Rect& dip_bounds) {
@@ skipping 227 matching lines @@
   return primary_screen_win_display;
 }
 
 ScreenWinDisplay ScreenWin::GetScreenWinDisplayNearestDIPRect(
     const gfx::Rect& dip_rect) const {
   ScreenWinDisplay closest_screen_win_display;
   int64_t closest_distance_squared = INT64_MAX;
   for (const auto& screen_win_display : screen_win_displays_) {
     display::Display display = screen_win_display.display();
     gfx::Rect dip_bounds = display.bounds();
+    if (dip_rect.Intersects(dip_bounds))
+      return screen_win_display;
     int64_t distance_squared = SquaredDistanceBetweenRects(dip_rect,
                                                            dip_bounds);
-    if (distance_squared == 0) {
-      return screen_win_display;
-    } else if (distance_squared < closest_distance_squared) {
+    if (distance_squared < closest_distance_squared) {
       closest_distance_squared = distance_squared;
       closest_screen_win_display = screen_win_display;
     }
   }
   return closest_screen_win_display;
 }
 
 ScreenWinDisplay ScreenWin::GetPrimaryScreenWinDisplay() const {
   MONITORINFOEX monitor_info = MonitorInfoFromWindow(nullptr,
                                                      MONITOR_DEFAULTTOPRIMARY);
@@ skipping 41 matching lines @@
     if (std::find(unique_scale_factors.begin(), unique_scale_factors.end(),
                   reported_scale) == unique_scale_factors.end()) {
       unique_scale_factors.push_back(reported_scale);
       UMA_HISTOGRAM_SPARSE_SLOWLY("UI.DeviceScale", reported_scale);
     }
   }
 }
 
 }  // namespace win
 }  // namespace display