Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 2267033002: Remove --promise-extra flag (Closed)

Created:
4 years, 4 months ago by Dan Ehrenberg
Modified:
4 years, 4 months ago
Reviewers:
adamk
CC:
Michael Hablich, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove --promise-extra flag This flag was shipped on in 52, so it's due for removal. The patch includes removing the deprecated and unused-in-Blink API Promise::Chain, and many test updates. R=adamk@chromium.org BUG=v8:4633 Committed: https://crrev.com/b2a257f9ffb63a1e1bd0d89a6ef297a1f595f5cc Cr-Commit-Position: refs/heads/master@{#38804}

Patch Set 1 #

Patch Set 2 : Skip big object test in one configuration which is timing out #

Patch Set 3 : Fix syntax for skip #

Patch Set 4 : Fix syntax for skip #

Unified diffs Side-by-side diffs Delta from patch set Stats (+214 lines, -427 lines) Patch
M BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M include/v8.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/api.cc View 1 chunk +0 lines, -30 lines 0 comments Download
M src/bootstrapper.cc View 5 chunks +0 lines, -6 lines 0 comments Download
M src/contexts.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/flag-definitions.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/js/prologue.js View 1 chunk +0 lines, -3 lines 0 comments Download
M src/js/promise.js View 4 chunks +0 lines, -28 lines 0 comments Download
D src/js/promise-extra.js View 1 chunk +0 lines, -26 lines 0 comments Download
M src/v8.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/es6/debug-promises/reentry.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/es6/debug-promises/reject-after-resolve.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/es6/debug-promises/reject-caught-all.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/es6/debug-promises/reject-caught-late.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/es6/debug-promises/reject-caught-uncaught.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/es6/debug-promises/reject-uncaught-all.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/es6/debug-promises/reject-uncaught-uncaught.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/es6/debug-promises/reject-with-invalid-reject.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/es6/debug-promises/reject-with-throw-in-reject.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/es6/debug-promises/reject-with-undefined-reject.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/es6/debug-promises/throw-caught-all.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/es6/debug-promises/throw-caught-late.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/es6/debug-promises/throw-caught-uncaught.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/es6/debug-promises/throw-finally-caught-all.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/es6/debug-promises/throw-uncaught-all.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/es6/debug-promises/throw-uncaught-uncaught.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/es6/debug-promises/throw-with-throw-in-reject.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/es6/promise-internal-setter.js View 2 chunks +0 lines, -3 lines 0 comments Download
M test/mjsunit/es6/promises.js View 46 chunks +177 lines, -281 lines 0 comments Download
M test/mjsunit/es6/regress/regress-cr372788.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 27 (16 generated)
Dan Ehrenberg
4 years, 4 months ago (2016-08-22 17:42:52 UTC) #3
adamk
lgtm
4 years, 4 months ago (2016-08-22 18:06:36 UTC) #4
adamk
Hmm, my reading is that the flag was shipped in 52, not 51; update CL ...
4 years, 4 months ago (2016-08-22 18:07:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2267033002/1
4 years, 4 months ago (2016-08-22 18:09:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2267033002/20001
4 years, 4 months ago (2016-08-22 18:58:03 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: v8_win64_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/12902) v8_win64_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
4 years, 4 months ago (2016-08-22 19:08:25 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2267033002/30001
4 years, 4 months ago (2016-08-22 19:31:25 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: v8_win64_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/12905) v8_win64_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
4 years, 4 months ago (2016-08-22 19:41:13 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2267033002/50001
4 years, 4 months ago (2016-08-22 20:29:40 UTC) #24
commit-bot: I haz the power
Committed patchset #4 (id:50001)
4 years, 4 months ago (2016-08-22 21:34:52 UTC) #25
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 21:35:16 UTC) #27
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/b2a257f9ffb63a1e1bd0d89a6ef297a1f595f5cc
Cr-Commit-Position: refs/heads/master@{#38804}

Powered by Google App Engine
This is Rietveld 408576698