Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: src/api.cc

Issue 2267033002: Remove --promise-extra flag (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix syntax for skip Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « include/v8.h ('k') | src/bootstrapper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/api.cc
diff --git a/src/api.cc b/src/api.cc
index 241824a38daedfebc699f45fd8104516b963a5c6..6858a325c40a86dea6b2fa130591d36c4ac09ff5 100644
--- a/src/api.cc
+++ b/src/api.cc
@@ -6707,36 +6707,6 @@ void Promise::Resolver::Reject(Local<Value> value) {
}
-namespace {
-
-MaybeLocal<Promise> DoChain(Value* value, Local<Context> context,
- Local<Function> handler) {
- PREPARE_FOR_EXECUTION(context, Promise, Chain, Promise);
- auto self = Utils::OpenHandle(value);
- i::Handle<i::Object> argv[] = {Utils::OpenHandle(*handler)};
- i::Handle<i::Object> result;
- has_pending_exception = !i::Execution::Call(isolate, isolate->promise_chain(),
- self, arraysize(argv), argv)
- .ToHandle(&result);
- RETURN_ON_FAILED_EXECUTION(Promise);
- RETURN_ESCAPED(Local<Promise>::Cast(Utils::ToLocal(result)));
-}
-
-} // namespace
-
-
-MaybeLocal<Promise> Promise::Chain(Local<Context> context,
- Local<Function> handler) {
- return DoChain(this, context, handler);
-}
-
-
-Local<Promise> Promise::Chain(Local<Function> handler) {
- auto context = ContextFromHeapObject(Utils::OpenHandle(this));
- RETURN_TO_LOCAL_UNCHECKED(DoChain(this, context, handler), Promise);
-}
-
-
MaybeLocal<Promise> Promise::Catch(Local<Context> context,
Local<Function> handler) {
PREPARE_FOR_EXECUTION(context, Promise, Catch, Promise);
« no previous file with comments | « include/v8.h ('k') | src/bootstrapper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698