Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issue 2267023003: ash: Eliminate PointerWatcherDelegate (Closed)

Created:
4 years, 4 months ago by James Cook
Modified:
4 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ash: Eliminate PointerWatcherDelegate Now that ash_sysui is unused the aura implementation is the only one and we don't need a delegate. * Remove CreatePointerWatcherDelegate() from ShellDelegate * Rename PointerWatcherDelegateAura to PointerWatcherAdapter * Call directly into PointerWatcherAdapter from WmShellAura and eliminate ash::Shell::AddPointerWatcher * Delete ash/sysui/pointer_watcher_delegate_mus.* No behavior changes. BUG=639883 TEST=ash_unittests Committed: https://crrev.com/0a9d02e415ae8da70750a964aaa7bb393ad2612c Cr-Commit-Position: refs/heads/master@{#413599}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -490 lines) Patch
M ash/ash.gyp View 5 chunks +3 lines, -4 lines 0 comments Download
A + ash/aura/pointer_watcher_adapter.h View 4 chunks +13 lines, -10 lines 0 comments Download
A + ash/aura/pointer_watcher_adapter.cc View 6 chunks +11 lines, -12 lines 0 comments Download
A + ash/aura/pointer_watcher_adapter_unittest.cc View 4 chunks +6 lines, -8 lines 0 comments Download
M ash/aura/wm_shell_aura.h View 3 chunks +6 lines, -0 lines 0 comments Download
M ash/aura/wm_shell_aura.cc View 4 chunks +11 lines, -2 lines 0 comments Download
D ash/common/pointer_watcher_delegate.h View 1 chunk +0 lines, -28 lines 0 comments Download
M ash/common/shell_delegate.h View 2 chunks +0 lines, -4 lines 0 comments Download
M ash/mus/shell_delegate_mus.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/mus/shell_delegate_mus.cc View 2 chunks +0 lines, -7 lines 0 comments Download
D ash/pointer_watcher_delegate_aura.h View 1 chunk +0 lines, -64 lines 0 comments Download
D ash/pointer_watcher_delegate_aura.cc View 1 chunk +0 lines, -105 lines 0 comments Download
D ash/pointer_watcher_delegate_aura_unittest.cc View 1 chunk +0 lines, -136 lines 0 comments Download
M ash/shell.h View 4 chunks +0 lines, -6 lines 0 comments Download
M ash/shell.cc View 4 chunks +1 line, -13 lines 0 comments Download
M ash/shell/shell_delegate_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/shell/shell_delegate_impl.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M ash/sysui/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D ash/sysui/pointer_watcher_delegate_mus.h View 1 chunk +0 lines, -29 lines 0 comments Download
D ash/sysui/pointer_watcher_delegate_mus.cc View 1 chunk +0 lines, -26 lines 0 comments Download
M ash/sysui/shell_delegate_mus.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/sysui/shell_delegate_mus.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M ash/test/test_shell_delegate.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/test/test_shell_delegate.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate.cc View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
James Cook
sky, please take a look. (It feels good to delete code.)
4 years, 4 months ago (2016-08-22 17:41:45 UTC) #3
sky
LGTM
4 years, 4 months ago (2016-08-22 18:18:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2267023003/1
4 years, 4 months ago (2016-08-22 18:33:51 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/266076)
4 years, 4 months ago (2016-08-22 21:19:28 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2267023003/1
4 years, 4 months ago (2016-08-22 21:41:21 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-23 00:20:44 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-08-23 00:23:50 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0a9d02e415ae8da70750a964aaa7bb393ad2612c
Cr-Commit-Position: refs/heads/master@{#413599}

Powered by Google App Engine
This is Rietveld 408576698