Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Side by Side Diff: ash/aura/pointer_watcher_adapter.cc

Issue 2267023003: ash: Eliminate PointerWatcherDelegate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ash/aura/pointer_watcher_adapter.h ('k') | ash/aura/pointer_watcher_adapter_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ash/pointer_watcher_delegate_aura.h" 5 #include "ash/aura/pointer_watcher_adapter.h"
6 6
7 #include "ash/shell.h" 7 #include "ash/shell.h"
8 #include "ui/aura/client/screen_position_client.h" 8 #include "ui/aura/client/screen_position_client.h"
9 #include "ui/aura/window.h" 9 #include "ui/aura/window.h"
10 #include "ui/events/event.h" 10 #include "ui/events/event.h"
11 #include "ui/events/event_constants.h" 11 #include "ui/events/event_constants.h"
12 #include "ui/gfx/geometry/point.h" 12 #include "ui/gfx/geometry/point.h"
13 #include "ui/views/pointer_watcher.h" 13 #include "ui/views/pointer_watcher.h"
14 #include "ui/views/widget/widget.h" 14 #include "ui/views/widget/widget.h"
15 15
16 namespace ash { 16 namespace ash {
17 17
18 PointerWatcherDelegateAura::PointerWatcherDelegateAura() { 18 PointerWatcherAdapter::PointerWatcherAdapter() {
19 Shell::GetInstance()->AddPreTargetHandler(this); 19 Shell::GetInstance()->AddPreTargetHandler(this);
20 } 20 }
21 21
22 PointerWatcherDelegateAura::~PointerWatcherDelegateAura() { 22 PointerWatcherAdapter::~PointerWatcherAdapter() {
23 Shell::GetInstance()->RemovePreTargetHandler(this); 23 Shell::GetInstance()->RemovePreTargetHandler(this);
24 } 24 }
25 25
26 void PointerWatcherDelegateAura::AddPointerWatcher( 26 void PointerWatcherAdapter::AddPointerWatcher(views::PointerWatcher* watcher,
27 views::PointerWatcher* watcher, 27 bool wants_moves) {
28 bool wants_moves) {
29 // We only allow a watcher to be added once. That is, we don't consider 28 // We only allow a watcher to be added once. That is, we don't consider
30 // the pair of |watcher| and |wants_move| unique, just |watcher|. 29 // the pair of |watcher| and |wants_move| unique, just |watcher|.
31 if (wants_moves) { 30 if (wants_moves) {
32 DCHECK(!non_move_watchers_.HasObserver(watcher)); 31 DCHECK(!non_move_watchers_.HasObserver(watcher));
33 move_watchers_.AddObserver(watcher); 32 move_watchers_.AddObserver(watcher);
34 } else { 33 } else {
35 DCHECK(!move_watchers_.HasObserver(watcher)); 34 DCHECK(!move_watchers_.HasObserver(watcher));
36 non_move_watchers_.AddObserver(watcher); 35 non_move_watchers_.AddObserver(watcher);
37 } 36 }
38 } 37 }
39 38
40 void PointerWatcherDelegateAura::RemovePointerWatcher( 39 void PointerWatcherAdapter::RemovePointerWatcher(
41 views::PointerWatcher* watcher) { 40 views::PointerWatcher* watcher) {
42 non_move_watchers_.RemoveObserver(watcher); 41 non_move_watchers_.RemoveObserver(watcher);
43 move_watchers_.RemoveObserver(watcher); 42 move_watchers_.RemoveObserver(watcher);
44 } 43 }
45 44
46 void PointerWatcherDelegateAura::OnMouseEvent(ui::MouseEvent* event) { 45 void PointerWatcherAdapter::OnMouseEvent(ui::MouseEvent* event) {
47 if (event->type() == ui::ET_MOUSE_CAPTURE_CHANGED) { 46 if (event->type() == ui::ET_MOUSE_CAPTURE_CHANGED) {
48 FOR_EACH_OBSERVER(views::PointerWatcher, non_move_watchers_, 47 FOR_EACH_OBSERVER(views::PointerWatcher, non_move_watchers_,
49 OnMouseCaptureChanged()); 48 OnMouseCaptureChanged());
50 FOR_EACH_OBSERVER(views::PointerWatcher, move_watchers_, 49 FOR_EACH_OBSERVER(views::PointerWatcher, move_watchers_,
51 OnMouseCaptureChanged()); 50 OnMouseCaptureChanged());
52 return; 51 return;
53 } 52 }
54 53
55 // For compatibility with the mus version, don't send drags. 54 // For compatibility with the mus version, don't send drags.
56 if (event->type() != ui::ET_MOUSE_PRESSED && 55 if (event->type() != ui::ET_MOUSE_PRESSED &&
57 event->type() != ui::ET_MOUSE_RELEASED && 56 event->type() != ui::ET_MOUSE_RELEASED &&
58 event->type() != ui::ET_MOUSE_MOVED) 57 event->type() != ui::ET_MOUSE_MOVED)
59 return; 58 return;
60 59
61 DCHECK(ui::PointerEvent::CanConvertFrom(*event)); 60 DCHECK(ui::PointerEvent::CanConvertFrom(*event));
62 NotifyWatchers(ui::PointerEvent(*event), *event); 61 NotifyWatchers(ui::PointerEvent(*event), *event);
63 } 62 }
64 63
65 void PointerWatcherDelegateAura::OnTouchEvent(ui::TouchEvent* event) { 64 void PointerWatcherAdapter::OnTouchEvent(ui::TouchEvent* event) {
66 // For compatibility with the mus version, don't send drags. 65 // For compatibility with the mus version, don't send drags.
67 if (event->type() != ui::ET_TOUCH_PRESSED && 66 if (event->type() != ui::ET_TOUCH_PRESSED &&
68 event->type() != ui::ET_TOUCH_RELEASED) 67 event->type() != ui::ET_TOUCH_RELEASED)
69 return; 68 return;
70 69
71 DCHECK(ui::PointerEvent::CanConvertFrom(*event)); 70 DCHECK(ui::PointerEvent::CanConvertFrom(*event));
72 NotifyWatchers(ui::PointerEvent(*event), *event); 71 NotifyWatchers(ui::PointerEvent(*event), *event);
73 } 72 }
74 73
75 gfx::Point PointerWatcherDelegateAura::GetLocationInScreen( 74 gfx::Point PointerWatcherAdapter::GetLocationInScreen(
76 const ui::LocatedEvent& event) const { 75 const ui::LocatedEvent& event) const {
77 aura::Window* target = static_cast<aura::Window*>(event.target()); 76 aura::Window* target = static_cast<aura::Window*>(event.target());
78 gfx::Point location_in_screen = event.location(); 77 gfx::Point location_in_screen = event.location();
79 aura::client::GetScreenPositionClient(target->GetRootWindow()) 78 aura::client::GetScreenPositionClient(target->GetRootWindow())
80 ->ConvertPointToScreen(target, &location_in_screen); 79 ->ConvertPointToScreen(target, &location_in_screen);
81 return location_in_screen; 80 return location_in_screen;
82 } 81 }
83 82
84 views::Widget* PointerWatcherDelegateAura::GetTargetWidget( 83 views::Widget* PointerWatcherAdapter::GetTargetWidget(
85 const ui::LocatedEvent& event) const { 84 const ui::LocatedEvent& event) const {
86 aura::Window* window = static_cast<aura::Window*>(event.target()); 85 aura::Window* window = static_cast<aura::Window*>(event.target());
87 return views::Widget::GetTopLevelWidgetForNativeView(window); 86 return views::Widget::GetTopLevelWidgetForNativeView(window);
88 } 87 }
89 88
90 void PointerWatcherDelegateAura::NotifyWatchers( 89 void PointerWatcherAdapter::NotifyWatchers(
91 const ui::PointerEvent& event, 90 const ui::PointerEvent& event,
92 const ui::LocatedEvent& original_event) { 91 const ui::LocatedEvent& original_event) {
93 const gfx::Point screen_location(GetLocationInScreen(original_event)); 92 const gfx::Point screen_location(GetLocationInScreen(original_event));
94 views::Widget* target_widget = GetTargetWidget(original_event); 93 views::Widget* target_widget = GetTargetWidget(original_event);
95 FOR_EACH_OBSERVER( 94 FOR_EACH_OBSERVER(
96 views::PointerWatcher, move_watchers_, 95 views::PointerWatcher, move_watchers_,
97 OnPointerEventObserved(event, screen_location, target_widget)); 96 OnPointerEventObserved(event, screen_location, target_widget));
98 if (event.type() != ui::ET_POINTER_MOVED) { 97 if (event.type() != ui::ET_POINTER_MOVED) {
99 FOR_EACH_OBSERVER( 98 FOR_EACH_OBSERVER(
100 views::PointerWatcher, non_move_watchers_, 99 views::PointerWatcher, non_move_watchers_,
101 OnPointerEventObserved(event, screen_location, target_widget)); 100 OnPointerEventObserved(event, screen_location, target_widget));
102 } 101 }
103 } 102 }
104 103
105 } // namespace ash 104 } // namespace ash
OLDNEW
« no previous file with comments | « ash/aura/pointer_watcher_adapter.h ('k') | ash/aura/pointer_watcher_adapter_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698