Allow content script insertion on about:-URLs.

chrome/browser/extensions/user_script_master.cc

Index: chrome/browser/extensions/user_script_master.cc
diff --git a/chrome/browser/extensions/user_script_master.cc b/chrome/browser/extensions/user_script_master.cc
index 03afaa5ca7ed5c2665aaeccab30af74c6d46b58e..9cb40eebcb3b920192b0c05dc9fc89edd6409a7a 100644
--- a/chrome/browser/extensions/user_script_master.cc
+++ b/chrome/browser/extensions/user_script_master.cc
@@ -102,10 +102,14 @@ bool UserScriptMaster::ScriptReloader::ParseMetadataHeader(
 
       std::string value;
       if (GetDeclarationValue(line, kIncludeDeclaration, &value)) {
-        // We escape some characters that MatchPattern() considers special.
-        ReplaceSubstringsAfterOffset(&value, 0, "\\", "\\\\");
-        ReplaceSubstringsAfterOffset(&value, 0, "?", "\\?");
-        script->add_glob(value);
+        if (value == "about:blank") {

[not at google - send to devlin, 2014/04/21 19:56:22]

there should be a constant declared somewhere for this?

though did you add this line because of a test failure, or speculatively? it
looks like this is invoked from an @include statement and I don't know why that
would have about:blank in it.

[robwu, 2014/04/21 22:15:41]

Indeed, content::kAboutBlank if I'm not mistaken. Changed.
An "about:blank" glob would not grant access to about:blank unless the
matches_about_blank flag is set. It's easy to support "@include about:blank"
(just an extra conditional), so I've added this to be compatible with
Greasemonkey
(http://www.greasespot.net/2011/04/breaking-change-inject-into-aboutblank.html).

+          script->set_match_about_blank(true);
+        } else {
+          // We escape some characters that MatchPattern() considers special.
+          ReplaceSubstringsAfterOffset(&value, 0, "\\", "\\\\");
+          ReplaceSubstringsAfterOffset(&value, 0, "?", "\\?");
+          script->add_glob(value);
+        }
       } else if (GetDeclarationValue(line, kExcludeDeclaration, &value)) {
         ReplaceSubstringsAfterOffset(&value, 0, "\\", "\\\\");
         ReplaceSubstringsAfterOffset(&value, 0, "?", "\\?");