Allow content script insertion on about:-URLs.

chrome/browser/extensions/user_script_master.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/user_script_master.h"
 
 #include <map>
 #include <string>
 #include <vector>
 
@@ skipping 84 matching lines @@
 
     if (!in_metadata) {
       if (line.starts_with(kUserScriptBegin))
         in_metadata = true;
     } else {
       if (line.starts_with(kUserScriptEng))
         break;
 
       std::string value;
       if (GetDeclarationValue(line, kIncludeDeclaration, &value)) {
-        // We escape some characters that MatchPattern() considers special.
-        ReplaceSubstringsAfterOffset(&value, 0, "\\", "\\\\");
-        ReplaceSubstringsAfterOffset(&value, 0, "?", "\\?");
-        script->add_glob(value);
+        if (value == "about:blank") {

[not at google - send to devlin, 2014/04/21 19:56:22]

there should be a constant declared somewhere for this?

though did you add this line because of a test failure, or speculatively? it
looks like this is invoked from an @include statement and I don't know why that
would have about:blank in it.

[robwu, 2014/04/21 22:15:41]

Indeed, content::kAboutBlank if I'm not mistaken. Changed.
An "about:blank" glob would not grant access to about:blank unless the
matches_about_blank flag is set. It's easy to support "@include about:blank"
(just an extra conditional), so I've added this to be compatible with
Greasemonkey
(http://www.greasespot.net/2011/04/breaking-change-inject-into-aboutblank.html).

+          script->set_match_about_blank(true);
+        } else {
+          // We escape some characters that MatchPattern() considers special.
+          ReplaceSubstringsAfterOffset(&value, 0, "\\", "\\\\");
+          ReplaceSubstringsAfterOffset(&value, 0, "?", "\\?");
+          script->add_glob(value);
+        }
       } else if (GetDeclarationValue(line, kExcludeDeclaration, &value)) {
         ReplaceSubstringsAfterOffset(&value, 0, "\\", "\\\\");
         ReplaceSubstringsAfterOffset(&value, 0, "?", "\\?");
         script->add_exclude_glob(value);
       } else if (GetDeclarationValue(line, kNamespaceDeclaration, &value)) {
         script->set_name_space(value);
       } else if (GetDeclarationValue(line, kNameDeclaration, &value)) {
         script->set_name(value);
       } else if (GetDeclarationValue(line, kVersionDeclaration, &value)) {
         Version version(value);
@@ skipping 338 matching lines @@
 
   base::SharedMemoryHandle handle_for_process;
   if (!shared_memory->ShareToProcess(handle, &handle_for_process))
     return;  // This can legitimately fail if the renderer asserts at startup.
 
   if (base::SharedMemory::IsHandleValid(handle_for_process))
     process->Send(new ExtensionMsg_UpdateUserScripts(handle_for_process));
 }
 
 }  // namespace extensions