Allow content script insertion on about:-URLs.

extensions/common/url_pattern.cc

Index: extensions/common/url_pattern.cc
diff --git a/extensions/common/url_pattern.cc b/extensions/common/url_pattern.cc
index 477d3ddf080f65ea762dad056e27b11622d213cc..7cf1b8ce94c65bad16ae7ca82d783f7b5667e40a 100644
--- a/extensions/common/url_pattern.cc
+++ b/extensions/common/url_pattern.cc
@@ -27,6 +27,7 @@ const char* kValidSchemes[] = {
   content::kChromeUIScheme,
   extensions::kExtensionScheme,
   content::kFileSystemScheme,
+  content::kAboutScheme,
 };
 
 const int kValidSchemeMasks[] = {
@@ -37,6 +38,7 @@ const int kValidSchemeMasks[] = {
   URLPattern::SCHEME_CHROMEUI,
   URLPattern::SCHEME_EXTENSION,
   URLPattern::SCHEME_FILESYSTEM,
+  URLPattern::SCHEME_ABOUT,
 };
 
 COMPILE_ASSERT(arraysize(kValidSchemes) == arraysize(kValidSchemeMasks),
@@ -409,6 +411,10 @@ bool URLPattern::MatchesPath(const std::string& test) const {
   if (test + "/*" == path_escaped_)
     return true;
 
+  // If the path is a wildcard, allow any path.
+  if (path_escaped_ == "*" || path_escaped_ == "/*")

[not at google - send to devlin, 2014/04/18 16:04:55]

this will change host permissions beyond just about:*. it will means that
extensions can specify

http://*

as host permissions, when they couldn't previously, for better or for worse.
which isn't forwards compatible.

I'm thinking that a better, less invasive way of doing what you're going for
here is to add another option to executeScript and content_scripts like
"aboutBlank" in addition to "allFrames". A host permission for this doesn't seem
right.

+    return true;
+
   return MatchPattern(test, path_escaped_);
 }