Allow content script insertion on about:-URLs.

extensions/common/url_pattern.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/common/url_pattern.h"
 
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_piece.h"
 #include "base/strings/string_split.h"
 #include "base/strings/string_util.h"
 #include "content/public/common/url_constants.h"
 #include "extensions/common/constants.h"
 #include "url/gurl.h"
 #include "url/url_util.h"
 
 const char URLPattern::kAllUrlsPattern[] = "<all_urls>";
 
 namespace {
 
 // TODO(aa): What about more obscure schemes like data: and javascript: ?
 // Note: keep this array in sync with kValidSchemeMasks.
 const char* kValidSchemes[] = {
   content::kHttpScheme,
   content::kHttpsScheme,
   content::kFileScheme,
   content::kFtpScheme,
   content::kChromeUIScheme,
   extensions::kExtensionScheme,
   content::kFileSystemScheme,
+  content::kAboutScheme,
 };
 
 const int kValidSchemeMasks[] = {
   URLPattern::SCHEME_HTTP,
   URLPattern::SCHEME_HTTPS,
   URLPattern::SCHEME_FILE,
   URLPattern::SCHEME_FTP,
   URLPattern::SCHEME_CHROMEUI,
   URLPattern::SCHEME_EXTENSION,
   URLPattern::SCHEME_FILESYSTEM,
+  URLPattern::SCHEME_ABOUT,
 };
 
 COMPILE_ASSERT(arraysize(kValidSchemes) == arraysize(kValidSchemeMasks),
                must_keep_these_arrays_in_sync);
 
 const char kParseSuccess[] = "Success.";
 const char kParseErrorMissingSchemeSeparator[] = "Missing scheme separator.";
 const char kParseErrorInvalidScheme[] = "Invalid scheme.";
 const char kParseErrorWrongSchemeType[] = "Wrong scheme type.";
 const char kParseErrorEmptyHost[] = "Host can not be empty.";
@@ skipping 352 matching lines @@
 
   return test.host()[test.host().length() - host_.length() - 1] == '.';
 }
 
 bool URLPattern::MatchesPath(const std::string& test) const {
   // Make the behaviour of OverlapsWith consistent with MatchesURL, which is
   // need to match hosted apps on e.g. 'google.com' also run on 'google.com/'.
   if (test + "/*" == path_escaped_)
     return true;
 
+  // If the path is a wildcard, allow any path.
+  if (path_escaped_ == "*" || path_escaped_ == "/*")

[not at google - send to devlin, 2014/04/18 16:04:55]

this will change host permissions beyond just about:*. it will means that
extensions can specify

http://*

as host permissions, when they couldn't previously, for better or for worse.
which isn't forwards compatible.

I'm thinking that a better, less invasive way of doing what you're going for
here is to add another option to executeScript and content_scripts like
"aboutBlank" in addition to "allFrames". A host permission for this doesn't seem
right.

+    return true;
+
   return MatchPattern(test, path_escaped_);
 }
 
 const std::string& URLPattern::GetAsString() const {
   if (!spec_.empty())
     return spec_;
 
   if (match_all_urls_) {
     spec_ = kAllUrlsPattern;
     return spec_;
@@ skipping 114 matching lines @@
   }
 
   return result;
 }
 
 // static
 const char* URLPattern::GetParseResultString(
     URLPattern::ParseResult parse_result) {
   return kParseResultMessages[parse_result];
 }