Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(925)

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h

Issue 2266563002: Implement buffer{Sub}Data overloads with sub source. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h
diff --git a/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h b/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h
index 99ee04a0d65423587aee828781675fd640d1e168..8654801888d7f7436af687fba0614f5bbfc1a0d8 100644
--- a/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h
+++ b/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h
@@ -28,8 +28,20 @@ public:
~WebGL2RenderingContextBase() override;
/* Buffer objects */
+ void bufferData(GLenum, DOMArrayBufferView*, GLenum, GLuint, GLuint);
+ void bufferSubData(GLenum, GLintptr, DOMArrayBufferView*, GLuint, GLuint);
+ // Have to re-declare/re-define the following buffer{Sub}Data functions from base class.
+ // This is because the above buffer{Sub}Data() hides the name from base class.
+ void bufferData(GLenum target, long long size, GLenum usage);
+ void bufferData(GLenum target, DOMArrayBuffer* data, GLenum usage);
+ void bufferData(GLenum target, DOMArrayBufferView* data, GLenum usage);
+ void bufferSubData(GLenum target, long long offset, DOMArrayBuffer* data);
+ void bufferSubData(GLenum target, long long offset, const FlexibleArrayBufferView& data);
+
void copyBufferSubData(GLenum, GLenum, long long, long long, long long);
- void getBufferSubData(GLenum target, long long offset, DOMArrayBuffer* returnedData);
+ void getBufferSubData(GLenum, long long, DOMArrayBufferView*, GLuint, GLuint);
+ // TODO(zmo): Obsolete, remove after WebGL2 conformance tests are updated.
+ void getBufferSubData(GLenum, long long, DOMArrayBuffer*);
/* Framebuffer objects */
bool validateTexFuncLayer(const char*, GLenum texTarget, GLint layer);
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698