Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(777)

Issue 2266543002: Consistently use namespaced base::Version in component_updater code. (Closed)

Created:
4 years, 4 months ago by pwnall
Modified:
4 years, 4 months ago
Reviewers:
Sorin Jianu
CC:
chromium-reviews, waffles
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Consistently use namespaced base::Version in component_updater code. BUG=639416 Committed: https://crrev.com/15745b314cf0d0abdd84750becb37bebee0b12e0 Cr-Commit-Position: refs/heads/master@{#413255}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -38 lines) Patch
M chrome/browser/component_updater/component_installers_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/component_updater/pnacl_component_installer.cc View 10 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/component_updater/recovery_component_installer.cc View 8 chunks +10 lines, -9 lines 0 comments Download
M chrome/browser/component_updater/sw_reporter_installer_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/component_updater/swiftshader_component_installer.cc View 8 chunks +9 lines, -9 lines 0 comments Download
M components/component_updater/component_updater_service_unittest.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M components/component_updater/default_component_installer_unittest.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
pwnall
Can you please take a look at this CL as well? Thank you!
4 years, 4 months ago (2016-08-19 20:28:28 UTC) #3
Sorin Jianu
lgtm Thank you!
4 years, 4 months ago (2016-08-19 21:02:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2266543002/1
4 years, 4 months ago (2016-08-19 21:32:38 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-19 21:45:49 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-19 21:50:17 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/15745b314cf0d0abdd84750becb37bebee0b12e0
Cr-Commit-Position: refs/heads/master@{#413255}

Powered by Google App Engine
This is Rietveld 408576698