components/component_updater/component_updater_service_unittest.cc - Issue 2266543002: Consistently use namespaced base::Version in component_updater code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/component_updater/component_updater_service_unittest.cc

Issue 2266543002: Consistently use namespaced base::Version in component_updater code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/component_updater/swiftshader_component_installer.cc ('k') | components/component_updater/default_component_installer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/component_updater/component_updater_service_unittest.cc

diff --git a/components/component_updater/component_updater_service_unittest.cc b/components/component_updater/component_updater_service_unittest.cc

index b99d0fe25b529fb503230260ea72621876c6ced2..cdeed0d8a8d73367a697b75c8da6af6618b96ccf 100644

--- a/components/component_updater/component_updater_service_unittest.cc

+++ b/components/component_updater/component_updater_service_unittest.cc

@@ -73,8 +73,9 @@ class MockUpdateClient : public UpdateClient {

bool(const std::string& id, CrxUpdateItem* update_item));

MOCK_CONST_METHOD1(IsUpdating, bool(const std::string& id));

MOCK_METHOD0(Stop, void());

- MOCK_METHOD3(SendUninstallPing,

- void(const std::string& id, const Version& version, int reason));

+ MOCK_METHOD3(

+ SendUninstallPing,

+ void(const std::string& id, const base::Version& version, int reason));

private:

~MockUpdateClient() override;

@@ -255,12 +256,12 @@ TEST_F(ComponentUpdaterTest, RegisterComponent) {

CrxComponent crx_component1;

crx_component1.pk_hash.assign(abag_hash, abag_hash + arraysize(abag_hash));

- crx_component1.version = Version("1.0");

+ crx_component1.version = base::Version("1.0");

crx_component1.installer = installer;

CrxComponent crx_component2;

crx_component2.pk_hash.assign(jebg_hash, jebg_hash + arraysize(jebg_hash));

- crx_component2.version = Version("0.9");

+ crx_component2.version = base::Version("0.9");

crx_component2.installer = installer;

// Quit after two update checks have fired.

@@ -327,7 +328,7 @@ TEST_F(ComponentUpdaterTest, OnDemandUpdate) {

using update_client::jebg_hash;

CrxComponent crx_component;

crx_component.pk_hash.assign(jebg_hash, jebg_hash + arraysize(jebg_hash));

- crx_component.version = Version("0.9");

+ crx_component.version = base::Version("0.9");

crx_component.installer = new MockInstaller();

LoopHandler loop_handler(1);

@@ -385,7 +386,7 @@ TEST_F(ComponentUpdaterTest, MaybeThrottle) {

using update_client::jebg_hash;

CrxComponent crx_component;

crx_component.pk_hash.assign(jebg_hash, jebg_hash + arraysize(jebg_hash));

- crx_component.version = Version("0.9");

+ crx_component.version = base::Version("0.9");

crx_component.installer = installer;

LoopHandler loop_handler(1, quit_closure());