Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 2266533003: Add SplitUVPlanes and MergeUVPlanes (Closed)

Created:
4 years, 4 months ago by magjed_chromium
Modified:
4 years, 3 months ago
Reviewers:
fbarchard1
Base URL:
https://chromium.googlesource.com/libyuv/libyuv@master
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

Add SplitUVPlanes and MergeUVPlanes Add public methods SplitUVPlanes and MergeUVPlanes based on the optimized assembly functions that already exists. Also, de-duplicate the CPU dispatching code for these functions by moving them to helper functions. BUG=libyuv:629

Patch Set 1 : . #

Total comments: 9

Patch Set 2 : Rebase #

Total comments: 16
Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -171 lines) Patch
M include/libyuv/convert.h View 1 1 chunk +7 lines, -0 lines 2 comments Download
M include/libyuv/convert_from.h View 1 chunk +7 lines, -0 lines 3 comments Download
M include/libyuv/row.h View 2 chunks +10 lines, -0 lines 2 comments Download
M source/convert.cc View 1 2 chunks +12 lines, -44 lines 2 comments Download
M source/convert_from.cc View 1 chunk +25 lines, -47 lines 3 comments Download
M source/convert_from_argb.cc View 2 chunks +1 line, -26 lines 0 comments Download
M source/planar_functions.cc View 9 chunks +22 lines, -54 lines 3 comments Download
M source/row_common.cc View 3 chunks +51 lines, -0 lines 1 comment Download

Messages

Total messages: 7 (4 generated)
magjed_chromium
Frank - please take a look.
4 years, 4 months ago (2016-08-20 16:00:22 UTC) #5
fbarchard1
https://codereview.chromium.org/2266533003/diff/40001/include/libyuv/convert.h File include/libyuv/convert.h (right): https://codereview.chromium.org/2266533003/diff/40001/include/libyuv/convert.h#newcode206 include/libyuv/convert.h:206: int SplitUVPlanes(const uint8* src_uv, int src_stride_uv, This belongs in ...
4 years, 4 months ago (2016-08-24 17:42:24 UTC) #6
magjed_chromium
4 years, 3 months ago (2016-08-25 14:03:46 UTC) #7
Now I finally get a review, but you have already taken my CL, changed it and
landed it without any input from me. Since I uploaded this CL, you have landed 4
CL:s that address the same issue:
'NV12ToI420 use SplitPlane function' https://codereview.chromium.org/2267303002
'NV12 allow NULL for Y' https://codereview.chromium.org/2276703002
'Allow NULL for dst_y in planar formats.'
https://codereview.chromium.org/2271053003
'Add SplitUVPlanes and MergeUVPlanes' https://codereview.chromium.org/2277603004
You have not even given me the chance to review any of these CL:s. I am not sure
how to collaborate with you.

Powered by Google App Engine
This is Rietveld 408576698