Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2271053003: Allow NULL for dst_y in planar formats. BUG=libyuv:631 TEST=unittests build/pass (Closed)

Created:
4 years, 4 months ago by fbarchard1
Modified:
4 years, 3 months ago
Reviewers:
harryjin
Base URL:
https://chromium.googlesource.com/libyuv/libyuv@master
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

Allow NULL for dst_y in planar formats. BUG=libyuv:631 TEST=unittests build/pass BUG=libyuv:631 TEST=unittests build/pass R=harryjin@google.com Committed: https://chromium.googlesource.com/libyuv/libyuv/+/161e5c45696e45cab8f437eb9d8c6d7a0c1bb997

Patch Set 1 #

Patch Set 2 : Allow NULL for dst_y in planar formats. BUG=libyuv:631 TEST=unittests build/pass #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -19 lines) Patch
M source/convert.cc View 5 chunks +9 lines, -7 lines 2 comments Download
M source/convert_from.cc View 4 chunks +12 lines, -6 lines 0 comments Download
M source/planar_functions.cc View 5 chunks +12 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
fbarchard1
more Y optional fixes
4 years, 4 months ago (2016-08-24 02:50:50 UTC) #2
harryjin
lgtm
4 years, 4 months ago (2016-08-24 03:09:11 UTC) #3
fbarchard1
Committed patchset #2 (id:20001) manually as 161e5c45696e45cab8f437eb9d8c6d7a0c1bb997 (presubmit successful).
4 years, 4 months ago (2016-08-24 17:19:18 UTC) #5
fbarchard1
4 years, 3 months ago (2016-08-24 22:34:16 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/2271053003/diff/20001/source/convert.cc
File source/convert.cc (right):

https://codereview.chromium.org/2271053003/diff/20001/source/convert.cc#newco...
source/convert.cc:47: // TODO(fbarchard): support NULL for dst_y
check dst_y is not null.

https://codereview.chromium.org/2271053003/diff/20001/source/convert.cc#newco...
source/convert.cc:151: return I4xxToI420(src_y, src_stride_y,
consider CopyPlane here

Powered by Google App Engine
This is Rietveld 408576698