Optimize posting of WTF::Closure and improve scheduler test mocks

third_party/WebKit/Source/core/dom/ScriptRunnerTest.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/dom/ScriptRunner.h"
 
 #include "core/dom/Document.h"
 #include "core/dom/Element.h"
 #include "core/dom/ScriptLoader.h"
 #include "platform/heap/Handle.h"
@@ skipping 56 matching lines @@
     WTF::Vector<int> m_order;
 };
 
 TEST_F(ScriptRunnerTest, QueueSingleScript_Async)
 {
     MockScriptLoader* scriptLoader = MockScriptLoader::create(m_element.get());
     m_scriptRunner->queueScriptForExecution(scriptLoader, ScriptRunner::ASYNC_EXECUTION);
     m_scriptRunner->notifyScriptReady(scriptLoader, ScriptRunner::ASYNC_EXECUTION);
 
     EXPECT_CALL(*scriptLoader, execute());
-    m_platform.mockWebScheduler()->runAllTasks();
+    m_platform.runUntilIdle();
 }
 
 TEST_F(ScriptRunnerTest, QueueSingleScript_InOrder)
 {
     MockScriptLoader* scriptLoader = MockScriptLoader::create(m_element.get());
     m_scriptRunner->queueScriptForExecution(scriptLoader, ScriptRunner::IN_ORDER_EXECUTION);
 
     EXPECT_CALL(*scriptLoader, isReady()).WillOnce(Return(true));
     EXPECT_CALL(*scriptLoader, execute());
 
     m_scriptRunner->notifyScriptReady(scriptLoader, ScriptRunner::IN_ORDER_EXECUTION);
 
-    m_platform.mockWebScheduler()->runAllTasks();
+    m_platform.runUntilIdle();
 }
 
 TEST_F(ScriptRunnerTest, QueueMultipleScripts_InOrder)
 {
     MockScriptLoader* scriptLoader1 = MockScriptLoader::create(m_element.get());
     MockScriptLoader* scriptLoader2 = MockScriptLoader::create(m_element.get());
     MockScriptLoader* scriptLoader3 = MockScriptLoader::create(m_element.get());
 
     HeapVector<Member<MockScriptLoader>> scriptLoaders;
     scriptLoaders.append(scriptLoader1);
@@ skipping 17 matching lines @@
     for (size_t i = 0; i < scriptLoaders.size(); ++i) {
         EXPECT_CALL(*scriptLoaders[i], isReady())
             .WillRepeatedly(Invoke([&isReady, i] {
                 return isReady[i];
             }));
     }
 
     for (int i = 2; i >= 0; i--) {
         isReady[i] = true;
         m_scriptRunner->notifyScriptReady(scriptLoaders[i], ScriptRunner::IN_ORDER_EXECUTION);
-        m_platform.mockWebScheduler()->runAllTasks();
+        m_platform.runUntilIdle();
     }
 
     // But ensure the scripts were run in the expected order.
     EXPECT_THAT(m_order, ElementsAre(1, 2, 3));
 }
 
 TEST_F(ScriptRunnerTest, QueueMixedScripts)
 {
     MockScriptLoader* scriptLoader1 = MockScriptLoader::create(m_element.get());
     MockScriptLoader* scriptLoader2 = MockScriptLoader::create(m_element.get());
@@ skipping 34 matching lines @@
     EXPECT_CALL(*scriptLoader3, execute()).WillOnce(Invoke([this] {
         m_order.append(3);
     }));
     EXPECT_CALL(*scriptLoader4, execute()).WillOnce(Invoke([this] {
         m_order.append(4);
     }));
     EXPECT_CALL(*scriptLoader5, execute()).WillOnce(Invoke([this] {
         m_order.append(5);
     }));
 
-    m_platform.mockWebScheduler()->runAllTasks();
+    m_platform.runUntilIdle();
 
     // Async tasks are expected to run first.
     EXPECT_THAT(m_order, ElementsAre(4, 5, 1, 2, 3));
 }
 
 TEST_F(ScriptRunnerTest, QueueReentrantScript_Async)
 {
     MockScriptLoader* scriptLoader1 = MockScriptLoader::create(m_element.get());
     MockScriptLoader* scriptLoader2 = MockScriptLoader::create(m_element.get());
     MockScriptLoader* scriptLoader3 = MockScriptLoader::create(m_element.get());
@@ skipping 14 matching lines @@
         m_order.append(2);
         m_scriptRunner->notifyScriptReady(scriptLoader, ScriptRunner::ASYNC_EXECUTION);
     }));
 
     EXPECT_CALL(*scriptLoader3, execute()).WillOnce(Invoke([this] {
         m_order.append(3);
     }));
 
     // Make sure that re-entrant calls to notifyScriptReady don't cause ScriptRunner::execute to do
     // more work than expected.
-    m_platform.mockWebScheduler()->runSingleTask();
+    m_platform.runSingleTask();
     EXPECT_THAT(m_order, ElementsAre(1));
 
-    m_platform.mockWebScheduler()->runSingleTask();
+    m_platform.runSingleTask();
     EXPECT_THAT(m_order, ElementsAre(1, 2));
 
-    m_platform.mockWebScheduler()->runSingleTask();
+    m_platform.runSingleTask();
     EXPECT_THAT(m_order, ElementsAre(1, 2, 3));
 }
 
 TEST_F(ScriptRunnerTest, QueueReentrantScript_InOrder)
 {
     MockScriptLoader* scriptLoader1 = MockScriptLoader::create(m_element.get());
     MockScriptLoader* scriptLoader2 = MockScriptLoader::create(m_element.get());
     MockScriptLoader* scriptLoader3 = MockScriptLoader::create(m_element.get());
 
     EXPECT_CALL(*scriptLoader1, isReady()).WillRepeatedly(Return(true));
@@ skipping 18 matching lines @@
             m_scriptRunner->queueScriptForExecution(scriptLoader, ScriptRunner::IN_ORDER_EXECUTION);
             m_scriptRunner->notifyScriptReady(scriptLoader3, ScriptRunner::IN_ORDER_EXECUTION);
         }));
 
     EXPECT_CALL(*scriptLoader3, execute()).WillOnce(Invoke([this] {
         m_order.append(3);
     }));
 
     // Make sure that re-entrant calls to queueScriptForExecution don't cause ScriptRunner::execute to do
     // more work than expected.
-    m_platform.mockWebScheduler()->runSingleTask();
+    m_platform.runSingleTask();
     EXPECT_THAT(m_order, ElementsAre(1));
 
-    m_platform.mockWebScheduler()->runSingleTask();
+    m_platform.runSingleTask();
     EXPECT_THAT(m_order, ElementsAre(1, 2));
 
-    m_platform.mockWebScheduler()->runSingleTask();
+    m_platform.runSingleTask();
     EXPECT_THAT(m_order, ElementsAre(1, 2, 3));
 }
 
 TEST_F(ScriptRunnerTest, QueueReentrantScript_ManyAsyncScripts)
 {
     MockScriptLoader* scriptLoaders[20];
     for (int i = 0; i < 20; i++)
         scriptLoaders[i] = nullptr;
 
     for (int i = 0; i < 20; i++) {
@@ skipping 11 matching lines @@
 
     m_scriptRunner->notifyScriptReady(scriptLoaders[0], ScriptRunner::ASYNC_EXECUTION);
     m_scriptRunner->notifyScriptReady(scriptLoaders[1], ScriptRunner::ASYNC_EXECUTION);
 
     EXPECT_CALL(*scriptLoaders[0], execute()).WillOnce(Invoke([&scriptLoaders, this] {
         for (int i = 2; i < 20; i++)
             m_scriptRunner->notifyScriptReady(scriptLoaders[i], ScriptRunner::ASYNC_EXECUTION);
         m_order.append(0);
     }));
 
-    m_platform.mockWebScheduler()->runAllTasks();
+    m_platform.runUntilIdle();
 
     int expected[] = {
         0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19
     };
 
     EXPECT_THAT(m_order, testing::ElementsAreArray(expected));
 }
 
 TEST_F(ScriptRunnerTest, ResumeAndSuspend_InOrder)
 {
@@ skipping 29 matching lines @@
     EXPECT_CALL(*scriptLoader2, isReady())
         .WillRepeatedly(Return(true));
     EXPECT_CALL(*scriptLoader3, isReady())
         .WillRepeatedly(Return(false));
     m_scriptRunner->notifyScriptReady(scriptLoader2, ScriptRunner::IN_ORDER_EXECUTION);
 
     EXPECT_CALL(*scriptLoader3, isReady())
         .WillRepeatedly(Return(true));
     m_scriptRunner->notifyScriptReady(scriptLoader3, ScriptRunner::IN_ORDER_EXECUTION);
 
-    m_platform.mockWebScheduler()->runSingleTask();
+    m_platform.runSingleTask();
     m_scriptRunner->suspend();
     m_scriptRunner->resume();
-    m_platform.mockWebScheduler()->runAllTasks();
+    m_platform.runUntilIdle();
 
     // Make sure elements are correct and in right order.
     EXPECT_THAT(m_order, ElementsAre(1, 2, 3));
 }
 
 TEST_F(ScriptRunnerTest, ResumeAndSuspend_Async)
 {
     MockScriptLoader* scriptLoader1 = MockScriptLoader::create(m_element.get());
     MockScriptLoader* scriptLoader2 = MockScriptLoader::create(m_element.get());
     MockScriptLoader* scriptLoader3 = MockScriptLoader::create(m_element.get());
@@ skipping 12 matching lines @@
         }));
     EXPECT_CALL(*scriptLoader2, execute())
         .WillOnce(Invoke([this] {
             m_order.append(2);
         }));
     EXPECT_CALL(*scriptLoader3, execute())
         .WillOnce(Invoke([this] {
             m_order.append(3);
         }));
 
-    m_platform.mockWebScheduler()->runSingleTask();
+    m_platform.runSingleTask();
     m_scriptRunner->suspend();
     m_scriptRunner->resume();
-    m_platform.mockWebScheduler()->runAllTasks();
+    m_platform.runUntilIdle();
 
     // Make sure elements are correct.
     EXPECT_THAT(m_order, WhenSorted(ElementsAre(1, 2, 3)));
 }
 
 TEST_F(ScriptRunnerTest, LateNotifications)
 {
     MockScriptLoader* scriptLoader1 = MockScriptLoader::create(m_element.get());
     MockScriptLoader* scriptLoader2 = MockScriptLoader::create(m_element.get());
 
     EXPECT_CALL(*scriptLoader1, isReady()).WillRepeatedly(Return(true));
     EXPECT_CALL(*scriptLoader2, isReady()).WillRepeatedly(Return(true));
 
     m_scriptRunner->queueScriptForExecution(scriptLoader1, ScriptRunner::IN_ORDER_EXECUTION);
     m_scriptRunner->queueScriptForExecution(scriptLoader2, ScriptRunner::IN_ORDER_EXECUTION);
 
     EXPECT_CALL(*scriptLoader1, execute()).WillOnce(Invoke([this] {
         m_order.append(1);
     }));
     EXPECT_CALL(*scriptLoader2, execute()).WillOnce(Invoke([this] {
         m_order.append(2);
     }));
 
     m_scriptRunner->notifyScriptReady(scriptLoader1, ScriptRunner::IN_ORDER_EXECUTION);
-    m_platform.mockWebScheduler()->runAllTasks();
+    m_platform.runUntilIdle();
 
     // At this moment all tasks can be already executed. Make sure that we do not crash here.
     m_scriptRunner->notifyScriptReady(scriptLoader2, ScriptRunner::IN_ORDER_EXECUTION);
-    m_platform.mockWebScheduler()->runAllTasks();
+    m_platform.runUntilIdle();
 
     EXPECT_THAT(m_order, ElementsAre(1, 2));
 }
 
 TEST_F(ScriptRunnerTest, TasksWithDeadScriptRunner)
 {
     Persistent<MockScriptLoader> scriptLoader1 = MockScriptLoader::create(m_element.get());
     Persistent<MockScriptLoader> scriptLoader2 = MockScriptLoader::create(m_element.get());
 
     EXPECT_CALL(*scriptLoader1, isReady()).WillRepeatedly(Return(true));
     EXPECT_CALL(*scriptLoader2, isReady()).WillRepeatedly(Return(true));
 
     m_scriptRunner->queueScriptForExecution(scriptLoader1, ScriptRunner::ASYNC_EXECUTION);
     m_scriptRunner->queueScriptForExecution(scriptLoader2, ScriptRunner::ASYNC_EXECUTION);
 
     m_scriptRunner->notifyScriptReady(scriptLoader1, ScriptRunner::ASYNC_EXECUTION);
     m_scriptRunner->notifyScriptReady(scriptLoader2, ScriptRunner::ASYNC_EXECUTION);
 
     m_scriptRunner.release();
 
     ThreadHeap::collectAllGarbage();
 
     // m_scriptRunner is gone. We need to make sure that ScriptRunner::Task do not access dead object.
     EXPECT_CALL(*scriptLoader1, execute()).Times(0);
     EXPECT_CALL(*scriptLoader2, execute()).Times(0);
 
-    m_platform.mockWebScheduler()->runAllTasks();
+    m_platform.runUntilIdle();
 }
 
 } // namespace blink