Optimize posting of WTF::Closure and improve scheduler test mocks

third_party/WebKit/Source/core/layout/ImageQualityControllerTest.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/layout/ImageQualityController.h"
 
 #include "core/layout/LayoutImage.h"
 #include "core/layout/LayoutTestHelper.h"
 #include "platform/graphics/GraphicsContext.h"
 #include "platform/graphics/paint/PaintController.h"
+#include "platform/scheduler/test/fake_web_task_runner.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "wtf/PtrUtil.h"
 #include <memory>
 
 namespace blink {
 
 class ImageQualityControllerTest : public RenderingTest {
 protected:
     ImageQualityController* controller() { return m_controller; }
 
@@ skipping 82 matching lines @@
 
 TEST_F(ImageQualityControllerTest, MediumQualityFilterForUnscaledImage)
 {
     setBodyInnerHTML("<img src='myimage'></img>");
     LayoutImage* img = toLayoutImage(document().body()->firstChild()->layoutObject());
 
     RefPtr<TestImageLowQuality> testImage = adoptRef(new TestImageLowQuality);
     EXPECT_EQ(InterpolationMedium, controller()->chooseInterpolationQuality(*img, testImage.get(), testImage.get(), LayoutSize(1, 1)));
 }
 
-class MockTaskRunner : public WebTaskRunner {
-public:
-    void setTime(double newTime) { m_time = newTime; }
-
-    MockTaskRunner()
-    : WebTaskRunner(), m_time(0.0), m_currentTask(nullptr)
-    { }
-
-    virtual ~MockTaskRunner()
-    {
-        if (m_currentTask)
-            delete m_currentTask;
-    }
-
-private:
-    void postTask(const WebTraceLocation&, Task*) override { }
-    void postDelayedTask(const WebTraceLocation&, Task* task, double) override
-    {
-        if (m_currentTask)
-            delete m_currentTask;
-        m_currentTask = task;
-
-    }
-    bool runsTasksOnCurrentThread() override { return true; }
-    std::unique_ptr<WebTaskRunner> clone() override { return nullptr; }
-    double virtualTimeSeconds() const override { return 0.0; }
-    double monotonicallyIncreasingVirtualTimeSeconds() const override { return m_time; }
-    SingleThreadTaskRunner* taskRunner() override { return nullptr; }
-
-    double m_time;
-    Task* m_currentTask;
-};
-
+// TODO(alexclarke): Remove this when possible.
 class MockTimer : public TaskRunnerTimer<ImageQualityController> {
 public:
     using TimerFiredFunction = typename TaskRunnerTimer<ImageQualityController>::TimerFiredFunction;
 
     MockTimer(ImageQualityController* o, TimerFiredFunction f)
         : TaskRunnerTimer(&m_taskRunner, o, f)
     {
     }
 
     void fire()
     {
         fired();
         stop();
     }
 
     void setTime(double newTime)
     {
         m_taskRunner.setTime(newTime);
     }
 
 private:
-    MockTaskRunner m_taskRunner;
+    scheduler::FakeWebTaskRunner m_taskRunner;
 };
 
 TEST_F(ImageQualityControllerTest, LowQualityFilterForResizingImage)
 {
     MockTimer* mockTimer = new MockTimer(controller(), &ImageQualityController::highQualityRepaintTimerFired);
     controller()->setTimer(wrapUnique(mockTimer));
     setBodyInnerHTML("<img src='myimage'></img>");
     LayoutImage* img = toLayoutImage(document().body()->firstChild()->layoutObject());
 
     RefPtr<TestImageLowQuality> testImage = adoptRef(new TestImageLowQuality);
@@ skipping 63 matching lines @@
     EXPECT_EQ(InterpolationLow, controller()->chooseInterpolationQuality(*img, testImage.get(), testImage.get(), LayoutSize(4, 4)));
 
     mockTimer->stop();
     EXPECT_FALSE(mockTimer->isActive());
     // Painted at the same size, so even though timer is still executing, don't go to low quality.
     EXPECT_EQ(InterpolationLow, controller()->chooseInterpolationQuality(*img, testImage.get(), testImage.get(), LayoutSize(4, 4)));
     // Check that the timer was not kicked. It should not have been, since the image was painted at the same size as last time.
     EXPECT_FALSE(mockTimer->isActive());
 }
 
+// TODO(chrishtr): Cancellable timers now exist (see WebTaskRunner::postCancellableDelayedTask), maybe revisit?
 TEST_F(ImageQualityControllerTest, DontRestartTimerUnlessAdvanced)
 {
     MockTimer* mockTimer = new MockTimer(controller(), &ImageQualityController::highQualityRepaintTimerFired);
     controller()->setTimer(wrapUnique(mockTimer));
     setBodyInnerHTML("<img src='myimage'></img>");
     LayoutImage* img = toLayoutImage(document().body()->firstChild()->layoutObject());
 
     RefPtr<TestImageLowQuality> testImage = adoptRef(new TestImageLowQuality);
 
     // Paint once. This will kick off a timer to see if we resize it during that timer's execution.
@@ skipping 11 matching lines @@
     // This animation is far enough in the future to make the timer restart, since it is half over.
     nextTime = 0.1 + ImageQualityController::cTimerRestartThreshold + 0.01;
     EXPECT_EQ(true, controller()->shouldPaintAtLowQuality(*img, testImage.get(), testImage.get(), LayoutSize(4, 4), nextTime));
     // Now the timer has restarted, leading to a larger fire interval.
     EXPECT_EQ(ImageQualityController::cLowQualityTimeThreshold, mockTimer->nextFireInterval());
 }
 
 #endif
 
 } // namespace blink