Fix couple problems with in-body incremental resolution.

Fix couple problems with in-body incremental resolution.

1. We were performing cache walking even though we don't need.
   This might take up to 50 ms for analyzer codebase.

2. STATIC_VARIABLE_RESOLUTION_ERRORS_IN_UNIT had null as a default
   value, which is not something what incremental resolver expected.

R=brianwilkerson@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/e95eb9e794ddb607d67e499d41f5f962a811669e

[Brian Wilkerson, 2016-08-25 18:57:55]

lgtm

https://codereview.chromium.org/2266403008/diff/20001/pkg/analyzer/lib/src/co...
File pkg/analyzer/lib/src/context/cache.dart (right):

https://codereview.chromium.org/2266403008/diff/20001/pkg/analyzer/lib/src/co...
pkg/analyzer/lib/src/context/cache.dart:1284: bool gatherRequired() {
This looks like it ought to be a getter.

[scheglov, 2016-08-26 15:29:06]

Description was changed from

==========
Fix couple problems with in-body incremental resolution.

1. We were performing cache walking even though we don't need.
   This might take up to 50 ms for analyzer codebase.

2. STATIC_VARIABLE_RESOLUTION_ERRORS_IN_UNIT had null as a default
   value, which is not something what incremental resolver expected.

R=brianwilkerson@google.com
BUG=
==========

to

==========
Fix couple problems with in-body incremental resolution.

1. We were performing cache walking even though we don't need.
   This might take up to 50 ms for analyzer codebase.

2. STATIC_VARIABLE_RESOLUTION_ERRORS_IN_UNIT had null as a default
   value, which is not something what incremental resolver expected.

R=brianwilkerson@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/e95eb9e794ddb607d67e499d41f5f962a811669e
==========

[scheglov, 2016-08-26 15:29:08]

Committed patchset #2 (id:20001) manually as
e95eb9e794ddb607d67e499d41f5f962a811669e (presubmit successful).