Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Side by Side Diff: pkg/analyzer/lib/src/task/dart.dart

Issue 2266403008: Fix couple problems with in-body incremental resolution. (Closed)
Patch Set: Actual changes. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library analyzer.src.task.dart; 5 library analyzer.src.task.dart;
6 6
7 import 'dart:collection'; 7 import 'dart:collection';
8 8
9 import 'package:analyzer/dart/ast/ast.dart'; 9 import 'package:analyzer/dart/ast/ast.dart';
10 import 'package:analyzer/dart/ast/token.dart'; 10 import 'package:analyzer/dart/ast/token.dart';
(...skipping 957 matching lines...) Expand 10 before | Expand all | Expand 10 after
968 /** 968 /**
969 * A list of the [AnalysisError]s reported while resolving static 969 * A list of the [AnalysisError]s reported while resolving static
970 * [INFERABLE_STATIC_VARIABLES_IN_UNIT] defined in a unit. 970 * [INFERABLE_STATIC_VARIABLES_IN_UNIT] defined in a unit.
971 * 971 *
972 * The result is only available for [LibrarySpecificUnit]s, and only when strong 972 * The result is only available for [LibrarySpecificUnit]s, and only when strong
973 * mode is enabled. 973 * mode is enabled.
974 */ 974 */
975 final ListResultDescriptor<AnalysisError> 975 final ListResultDescriptor<AnalysisError>
976 STATIC_VARIABLE_RESOLUTION_ERRORS_IN_UNIT = 976 STATIC_VARIABLE_RESOLUTION_ERRORS_IN_UNIT =
977 new ListResultDescriptor<AnalysisError>( 977 new ListResultDescriptor<AnalysisError>(
978 'STATIC_VARIABLE_RESOLUTION_ERRORS_IN_UNIT', null); 978 'STATIC_VARIABLE_RESOLUTION_ERRORS_IN_UNIT', AnalysisError.NO_ERRORS);
979 979
980 /** 980 /**
981 * The additional strong mode errors produced while verifying a 981 * The additional strong mode errors produced while verifying a
982 * compilation unit. 982 * compilation unit.
983 * 983 *
984 * The list will be empty if there were no errors, but will not be `null`. 984 * The list will be empty if there were no errors, but will not be `null`.
985 * 985 *
986 * The result is only available for [LibrarySpecificUnits]s representing a 986 * The result is only available for [LibrarySpecificUnits]s representing a
987 * compilation unit. 987 * compilation unit.
988 * 988 *
(...skipping 1660 matching lines...) Expand 10 before | Expand all | Expand 10 after
2649 return false; 2649 return false;
2650 } 2650 }
2651 return addChangedElements(referencedNames, targetLibrary); 2651 return addChangedElements(referencedNames, targetLibrary);
2652 } 2652 }
2653 2653
2654 @override 2654 @override
2655 void gatherEnd() { 2655 void gatherEnd() {
2656 currentVisitUnits.clear(); 2656 currentVisitUnits.clear();
2657 } 2657 }
2658 2658
2659 @override
2660 bool gatherRequired() {
2661 return true;
2662 }
2663
2659 bool hasAffectedHintsVerifyErrors( 2664 bool hasAffectedHintsVerifyErrors(
2660 ReferencedNames references, Source refLibrary) { 2665 ReferencedNames references, Source refLibrary) {
2661 for (String superName in references.superToSubs.keys) { 2666 for (String superName in references.superToSubs.keys) {
2662 if (isChangedOrClass(refLibrary, superName)) { 2667 if (isChangedOrClass(refLibrary, superName)) {
2663 _log(() => '$refLibrary hints/verify errors are affected because ' 2668 _log(() => '$refLibrary hints/verify errors are affected because '
2664 '${references.superToSubs[superName]} subclasses $superName'); 2669 '${references.superToSubs[superName]} subclasses $superName');
2665 return true; 2670 return true;
2666 } 2671 }
2667 } 2672 }
2668 for (String name in references.names) { 2673 for (String name in references.names) {
(...skipping 3998 matching lines...) Expand 10 before | Expand all | Expand 10 after
6667 6672
6668 @override 6673 @override
6669 bool moveNext() { 6674 bool moveNext() {
6670 if (_newSources.isEmpty) { 6675 if (_newSources.isEmpty) {
6671 return false; 6676 return false;
6672 } 6677 }
6673 currentTarget = _newSources.removeLast(); 6678 currentTarget = _newSources.removeLast();
6674 return true; 6679 return true;
6675 } 6680 }
6676 } 6681 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698