android_webview/tools/system_webview_shell/BUILD.gn - Issue 2266353003: [EXAMPLE] Change WebView Layout Test to Android JUnit 4 style

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/tools/system_webview_shell/BUILD.gn

Issue 2266353003: [EXAMPLE] Change WebView Layout Test to Android JUnit 4 style (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix errors Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | android_webview/tools/system_webview_shell/layout_tests/src/org/chromium/webview_shell/test/WebViewLayoutActivityTestRule.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/tools/system_webview_shell/BUILD.gn

diff --git a/android_webview/tools/system_webview_shell/BUILD.gn b/android_webview/tools/system_webview_shell/BUILD.gn

index bba8c479ab3d9d9fbf29d64f8db52fc8039fb651..5cfd595a37ad7822fd4197a6b384d38bf7282ed7 100644

--- a/android_webview/tools/system_webview_shell/BUILD.gn

+++ b/android_webview/tools/system_webview_shell/BUILD.gn

@@ -67,13 +67,17 @@ instrumentation_test_apk("system_webview_shell_layout_test_apk") {

android_manifest = "layout_tests/AndroidManifest.xml"

java_files = [

"layout_tests/src/org/chromium/webview_shell/test/WebViewLayoutTest.java",

- "layout_tests/src/org/chromium/webview_shell/test/WebViewLayoutTestRunner.java",

+ "layout_tests/src/org/chromium/webview_shell/test/WebViewLayoutActivityTestRule.java",

"layout_tests/src/org/chromium/webview_shell/test/WebViewThreadTest.java",

]

deps = [

"//base:base_java",

"//base:base_java_test_support",

"//testing/android/reporter:reporter_java",

+ "//third_party/android_support_test_runner:exposed_instrumentation_api_publish_java",

+ "//third_party/android_support_test_runner:rules_java",

+ "//third_party/android_support_test_runner:runner_java",

+ "//third_party/junit",

]

data = [

"test/data/",