Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2266343002: Converted Observatory heap-snapshot element (Closed)

Created:
4 years, 4 months ago by cbernaschina
Modified:
4 years, 4 months ago
Reviewers:
turnidge, rmacnak, Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fixed crash on back button #

Patch Set 3 : Added tests #

Patch Set 4 : Fixed styling problems #

Patch Set 5 : Added missing explanation text #

Total comments: 10

Patch Set 6 : Added loading messages #

Patch Set 7 : Addressed comments #

Patch Set 8 : Fixed tests #

Patch Set 9 : Removed debug code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1122 lines, -691 lines) Patch
M runtime/observatory/lib/elements.dart View 4 chunks +3 lines, -1 line 0 comments Download
A + runtime/observatory/lib/heap_snapshot.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M runtime/observatory/lib/models.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/observatory/lib/object_graph.dart View 1 2 3 4 5 1 chunk +28 lines, -24 lines 0 comments Download
M runtime/observatory/lib/repositories.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/observatory/lib/service.dart View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/app/page.dart View 2 chunks +17 lines, -7 lines 0 comments Download
M runtime/observatory/lib/src/elements/class_view.dart View 2 chunks +7 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/css/shared.css View 1 2 3 4 5 2 chunks +66 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/heap_snapshot.dart View 1 2 3 4 5 6 7 8 1 chunk +365 lines, -418 lines 0 comments Download
D runtime/observatory/lib/src/elements/heap_snapshot.html View 1 chunk +0 lines, -198 lines 0 comments Download
M runtime/observatory/lib/src/elements/service_view.html View 1 chunk +0 lines, -2 lines 0 comments Download
A runtime/observatory/lib/src/heap_snapshot/heap_snapshot.dart View 1 2 3 4 5 1 chunk +226 lines, -0 lines 0 comments Download
A runtime/observatory/lib/src/models/objects/heap_snapshot.dart View 1 chunk +44 lines, -0 lines 0 comments Download
A runtime/observatory/lib/src/models/repositories/heap_snapshot.dart View 1 2 3 4 5 6 1 chunk +39 lines, -0 lines 0 comments Download
A runtime/observatory/lib/src/repositories/heap_snapshot.dart View 1 2 3 4 5 6 1 chunk +112 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 1 2 3 4 5 4 chunks +9 lines, -34 lines 0 comments Download
M runtime/observatory/observatory_sources.gypi View 1 2 3 6 chunks +5 lines, -1 line 0 comments Download
A runtime/observatory/tests/observatory_ui/heap_snapshot/element_test.dart View 1 2 1 chunk +70 lines, -0 lines 0 comments Download
A + runtime/observatory/tests/observatory_ui/heap_snapshot/element_test.html View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks.dart View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
A runtime/observatory/tests/observatory_ui/mocks/objects/heap_snapshot.dart View 1 2 1 chunk +66 lines, -0 lines 0 comments Download
A runtime/observatory/tests/observatory_ui/mocks/repositories/heap_snapshot.dart View 1 2 3 4 5 6 1 chunk +47 lines, -0 lines 0 comments Download
M runtime/observatory/tests/service/dominator_tree_test.dart View 1 2 3 4 5 6 7 2 chunks +5 lines, -2 lines 0 comments Download
M runtime/observatory/tests/service/graph_test.dart View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 15 (3 generated)
cbernaschina
4 years, 4 months ago (2016-08-23 01:20:43 UTC) #2
cbernaschina
4 years, 4 months ago (2016-08-23 02:52:17 UTC) #3
cbernaschina
Updated issue description
4 years, 4 months ago (2016-08-23 14:30:27 UTC) #5
cbernaschina
4 years, 4 months ago (2016-08-23 15:18:10 UTC) #6
rmacnak
https://codereview.chromium.org/2266343002/diff/80001/runtime/observatory/lib/src/elements/heap_snapshot.dart File runtime/observatory/lib/src/elements/heap_snapshot.dart (right): https://codereview.chromium.org/2266343002/diff/80001/runtime/observatory/lib/src/elements/heap_snapshot.dart#newcode128 runtime/observatory/lib/src/elements/heap_snapshot.dart:128: switch (_progress.status) { Because computing the dominator tree can ...
4 years, 4 months ago (2016-08-23 16:57:09 UTC) #7
rmacnak
https://codereview.chromium.org/2266343002/diff/80001/runtime/observatory/lib/src/elements/heap_snapshot.dart File runtime/observatory/lib/src/elements/heap_snapshot.dart (right): https://codereview.chromium.org/2266343002/diff/80001/runtime/observatory/lib/src/elements/heap_snapshot.dart#newcode337 runtime/observatory/lib/src/elements/heap_snapshot.dart:337: element.children[0].text = Utils.formatSize(node.shallowSize); retainedSize
4 years, 4 months ago (2016-08-23 17:01:02 UTC) #8
cbernaschina
4 years, 4 months ago (2016-08-23 17:23:10 UTC) #9
cbernaschina
https://codereview.chromium.org/2266343002/diff/80001/runtime/observatory/lib/src/elements/heap_snapshot.dart File runtime/observatory/lib/src/elements/heap_snapshot.dart (right): https://codereview.chromium.org/2266343002/diff/80001/runtime/observatory/lib/src/elements/heap_snapshot.dart#newcode128 runtime/observatory/lib/src/elements/heap_snapshot.dart:128: switch (_progress.status) { On 2016/08/23 16:57:09, rmacnak wrote: > ...
4 years, 4 months ago (2016-08-23 17:28:28 UTC) #10
rmacnak
lgtm
4 years, 4 months ago (2016-08-23 17:41:50 UTC) #11
cbernaschina
4 years, 4 months ago (2016-08-23 18:25:50 UTC) #12
cbernaschina
4 years, 4 months ago (2016-08-23 19:52:55 UTC) #13
cbernaschina
4 years, 4 months ago (2016-08-23 19:55:53 UTC) #15
Message was sent while issue was closed. 
Committed patchset #9 (id:160001) manually as
547d71add7ab9e053f56831b47fffb70ac090343 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698