Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1659)

Unified Diff: runtime/observatory/lib/src/elements/class_view.dart

Issue 2266343002: Converted Observatory heap-snapshot element (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Removed debug code Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/observatory/lib/src/app/page.dart ('k') | runtime/observatory/lib/src/elements/css/shared.css » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/lib/src/elements/class_view.dart
diff --git a/runtime/observatory/lib/src/elements/class_view.dart b/runtime/observatory/lib/src/elements/class_view.dart
index b101fbfa6b657dab7c45d356ec9946984ddc7127..849c3769293337740867dd46e54a2b2f083affb3 100644
--- a/runtime/observatory/lib/src/elements/class_view.dart
+++ b/runtime/observatory/lib/src/elements/class_view.dart
@@ -9,6 +9,7 @@ import 'observatory_element.dart';
import 'sample_buffer_control.dart';
import 'stack_trace_tree_config.dart';
import 'cpu_profile/virtual_tree.dart';
+import 'package:observatory/heap_snapshot.dart';
import 'package:observatory/elements.dart';
import 'package:observatory/models.dart' as M;
import 'package:observatory/service.dart';
@@ -42,8 +43,13 @@ class ClassViewElement extends ObservatoryElement {
Future<ServiceObject> retainedToplist(var limit) {
return cls.isolate.fetchHeapSnapshot(true).last
+ .then((RawHeapSnapshot raw) async {
+ final snapshot = new HeapSnapshot();
+ await snapshot.loadProgress(cls.isolate, raw);
+ return snapshot;
+ })
.then((HeapSnapshot snapshot) =>
- Future.wait(snapshot.getMostRetained(classId: cls.vmCid,
+ Future.wait(snapshot.getMostRetained(cls.isolate, classId: cls.vmCid,
limit: 10)))
.then((List<ServiceObject> most) {
mostRetained = new ObservableList.from(most);
« no previous file with comments | « runtime/observatory/lib/src/app/page.dart ('k') | runtime/observatory/lib/src/elements/css/shared.css » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698