Issue 226633002: Commit changes after a reset.

Issue 226633002: Commit changes after a reset. (Closed)

Created:
6 years, 8 months ago by erikwright (departed)

Modified:
6 years, 8 months ago

Reviewers:
gab

CC:
chromium-reviews, erikwright+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Commit changes after a reset. BUG=360167 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262227

Patch Set 2 : Don't commit, just schedule. #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -14 lines)			Patch
M	base/prefs/json_pref_store.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	base/prefs/pref_filter.h	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/browser/prefs/pref_hash_filter.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/prefs/pref_hash_filter.cc	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/browser/prefs/pref_hash_filter_unittest.cc	View		9 chunks	+16 lines, -9 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

erikwright (departed)

gab: PTAL before I add someone from base/prefs

6 years, 8 months ago (2014-04-04 20:21:27 UTC) #1

gab

https://codereview.chromium.org/226633002/diff/1/base/prefs/json_pref_store.cc File base/prefs/json_pref_store.cc (right): https://codereview.chromium.org/226633002/diff/1/base/prefs/json_pref_store.cc#newcode320 base/prefs/json_pref_store.cc:320: writer_.DoScheduledWrite(); I don't think you need to commit changes, ...

6 years, 8 months ago (2014-04-04 21:02:07 UTC) #2

erikwright (departed)

PTAL. https://codereview.chromium.org/226633002/diff/1/base/prefs/json_pref_store.cc File base/prefs/json_pref_store.cc (right): https://codereview.chromium.org/226633002/diff/1/base/prefs/json_pref_store.cc#newcode320 base/prefs/json_pref_store.cc:320: writer_.DoScheduledWrite(); On 2014/04/04 21:02:07, gab wrote: > I ...

6 years, 8 months ago (2014-04-07 14:57:14 UTC) #3

erikwright (departed)

The CQ bit was checked by erikwright@chromium.org

6 years, 8 months ago (2014-04-07 18:08:30 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikwright@chromium.org/226633002/20001

6 years, 8 months ago (2014-04-07 18:09:19 UTC) #6

Message was sent while issue was closed.

Change committed as 262227

Expand Messages | Collapse Messages