base/prefs/pref_filter.h - Issue 226633002: Commit changes after a reset.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/prefs/pref_filter.h

Issue 226633002: Commit changes after a reset. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Don't commit, just schedule. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/prefs/pref_filter.h

diff --git a/base/prefs/pref_filter.h b/base/prefs/pref_filter.h

index 0cf78a93f3604b6ecdcbcfb23f4fb28af924a5ac..ce07f929c7a7fc94f1569f66d3e403eee0f3c355 100644

--- a/base/prefs/pref_filter.h

+++ b/base/prefs/pref_filter.h

@@ -24,7 +24,9 @@ class BASE_PREFS_EXPORT PrefFilter {

// Observers are notified.

// Changes made by a PrefFilter during FilterOnLoad do not result in

// notifications to |PrefStore::Observer|s.

- virtual void FilterOnLoad(base::DictionaryValue* pref_store_contents) = 0;

+ // Implementations should return true if they modify the dictionary, to allow

+ // the changes to be persisted.

+ virtual bool FilterOnLoad(base::DictionaryValue* pref_store_contents) = 0;

// Receives notification when a pref store value is changed, before Observers

// are notified.

« no previous file with comments | « base/prefs/json_pref_store.cc ('k') | chrome/browser/prefs/pref_hash_filter.h » ('j') | no next file with comments »