Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(761)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2266293003: Make chromium recipe module explicitly set GIT_MODE (Closed)

Created:
4 years, 3 months ago by agable
Modified:
4 years, 3 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -14 lines) Patch
M scripts/slave/recipe_modules/chromium/api.py View 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium_afl.expected/full_chromium_fyi_Afl_Upload_Linux_ASan.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium_gn_upload.expected/full_tryserver_chromium_linux_linux_chromium_gn_upload.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium_gn_upload.expected/full_tryserver_chromium_mac_mac_chromium_gn_upload.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium_gn_upload.expected/full_tryserver_chromium_win_win8_chromium_gn_upload.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium_libfuzzer.expected/full_chromium_fyi_Libfuzzer_Upload_Linux_ASan.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium_libfuzzer.expected/full_chromium_fyi_Libfuzzer_Upload_Linux_ASan_Debug.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium_libfuzzer.expected/full_chromium_fyi_Libfuzzer_Upload_Linux_MSan.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium_libfuzzer.expected/full_chromium_fyi_Libfuzzer_Upload_Linux_UBSan.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium_libfuzzer.expected/full_chromium_fyi_Libfuzzer_Upload_Mac_ASan.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium_upload_clang.expected/full_tryserver_chromium_linux_linux_upload_clang.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium_upload_clang.expected/full_tryserver_chromium_mac_mac_upload_clang.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium_upload_clang.expected/full_tryserver_chromium_win_win_upload_clang.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/win_analyze.expected/full_chromium_fyi_Chromium_Windows_Analyze.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
agable
4 years, 3 months ago (2016-08-23 22:34:00 UTC) #1
martiniss
lgtm stip, do you think we should get other chromium recipe owners to look at ...
4 years, 3 months ago (2016-08-23 22:50:08 UTC) #3
agable
+sergeyberezin, one of the OWNERS
4 years, 3 months ago (2016-08-24 00:04:19 UTC) #5
Sergey Berezin
lgtm
4 years, 3 months ago (2016-08-24 00:20:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2266293003/1
4 years, 3 months ago (2016-08-24 00:48:26 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-08-24 00:52:06 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/31cc13202dc48e3d0b43...

Powered by Google App Engine
This is Rietveld 408576698