scripts/slave/recipe_modules/chromium/api.py - Issue 2266293003: Make chromium recipe module explicitly set GIT_MODE

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/chromium/api.py

Issue 2266293003: Make chromium recipe module explicitly set GIT_MODE (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: scripts/slave/recipe_modules/chromium/api.py

diff --git a/scripts/slave/recipe_modules/chromium/api.py b/scripts/slave/recipe_modules/chromium/api.py

index fe534cafe188c94860b11801f553a22b5f828e8a..af29442bcd6982fbbe0c880b0b37466244248359 100644

--- a/scripts/slave/recipe_modules/chromium/api.py

+++ b/scripts/slave/recipe_modules/chromium/api.py

@@ -149,7 +149,8 @@ class ChromiumApi(recipe_api.RecipeApi):

# calling chromium.set_config(), above, because otherwise the chromium

# call would reset the gclient config to its defaults.

self.m.gclient.set_config(

- 'chromium', PATCH_PROJECT=self.m.properties.get('patch_project'))

+ 'chromium', GIT_MODE=True,

+ PATCH_PROJECT=self.m.properties.get('patch_project'))

for c in bot_config.get('gclient_apply_config', []):

self.m.gclient.apply_config(c)

« no previous file with comments | « no previous file | scripts/slave/recipes/chromium_afl.expected/full_chromium_fyi_Afl_Upload_Linux_ASan.json » ('j') | no next file with comments »