Chromium Code Reviews
Help | Chromium Project | Sign in
(48)

Issue 2266193002: Implement Field::SetHidden using Field::SetDisplay. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 months ago by tonikitoo
Modified:
7 months ago
Reviewers:
Tom Sepez, dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Implement Field::SetHidden using Field::SetDisplay. Following up on [1], where the duplicated logic in Field::SetDisplay was factored out into a helper function, CL further cleans up a related method: ::SetHidden. Field::SetHidden(true), for instance, is equivalent to calling Field::SetDisplay(1), whereas Field::SetHidden(false) is equivalent to Field::SetDisplay(0); No behavior change is expected. [1] https://codereview.chromium.org/2255843002 Committed: https://pdfium.googlesource.com/pdfium/+/a73b8fee8751dae443af9437007261e4a1827a4f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -59 lines) Patch
M fpdfsdk/javascript/Field.cpp View 1 chunk +2 lines, -59 lines 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 8 (4 generated)
tonikitoo
7 months ago (2016-08-22 20:49:18 UTC) #3
dsinclair
lgtm
7 months ago (2016-08-22 20:55:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2266193002/1
7 months ago (2016-08-22 20:55:47 UTC) #6
commit-bot: I haz the power
7 months ago (2016-08-22 21:06:52 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/a73b8fee8751dae443af9437007261e4a182...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld d1a128a62