Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 2265923002: Set WebPagePopupImpl's bounds even if they don't appear to have changed. (Closed)

Created:
4 years, 4 months ago by bokan
Modified:
4 years, 4 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Set WebPagePopupImpl's bounds even if they don't appear to have changed. In r389984 I tried to make WebPagePopupImpl::resize only call into setWindowRect (which sends an IPC to the browser process) if the bounds have actually changed. This uncovered a bug in Aura that was papered up by the fact that we repeatedly set the bounds. The proper way to fix this is in Aura itself but we'd like to merge this for release so I'm landing this quick fix to restore the previous behavior. I'm working on a proper fix in crrev.com/2228093003 BUG=633140 Review-Url: https://codereview.chromium.org/2263503003 Cr-Commit-Position: refs/heads/master@{#413288} (cherry picked from commit 10dc8b7652e6d30337d9bea0ff8bba2592942751) Committed: https://chromium.googlesource.com/chromium/src/+/09f1017cc167a54a1ed47b7f9aca1ed2bc177eda

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M third_party/WebKit/Source/web/WebPagePopupImpl.cpp View 1 chunk +5 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
bokan
4 years, 4 months ago (2016-08-22 12:49:59 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
09f1017cc167a54a1ed47b7f9aca1ed2bc177eda.

Powered by Google App Engine
This is Rietveld 408576698