Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Issue 2263503003: Set WebPagePopupImpl's bounds even if they don't appear to have changed. (Closed)

Created:
4 years, 4 months ago by bokan
Modified:
4 years, 4 months ago
CC:
blink-reviews, chromium-reviews, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set WebPagePopupImpl's bounds even if they don't appear to have changed. In r389984 I tried to make WebPagePopupImpl::resize only call into setWindowRect (which sends an IPC to the browser process) if the bounds have actually changed. This uncovered a bug in Aura that was papered up by the fact that we repeatedly set the bounds. The proper way to fix this is in Aura itself but we'd like to merge this for release so I'm landing this quick fix to restore the previous behavior. I'm working on a proper fix in crrev.com/2228093003 BUG=633140 Committed: https://crrev.com/10dc8b7652e6d30337d9bea0ff8bba2592942751 Cr-Commit-Position: refs/heads/master@{#413288}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M third_party/WebKit/Source/web/WebPagePopupImpl.cpp View 1 chunk +5 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
bokan
Alexandre, could you please take a look today? We'd like to merge this to M53 ...
4 years, 4 months ago (2016-08-19 21:23:40 UTC) #3
aelias_OOO_until_Jul13
lgtm
4 years, 4 months ago (2016-08-19 21:29:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2263503003/1
4 years, 4 months ago (2016-08-19 21:30:29 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-19 23:45:39 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-19 23:47:10 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/10dc8b7652e6d30337d9bea0ff8bba2592942751
Cr-Commit-Position: refs/heads/master@{#413288}

Powered by Google App Engine
This is Rietveld 408576698