Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(615)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2265903002: Add debug code to catch faulty interceptor (Closed)

Created:
4 years, 4 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 4 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add debug code to catch faulty interceptor BUG=chromium:625155 R=jkummerow@chromium.org Committed: https://crrev.com/d181e6e1e6f95ee9c8005a2ad0fc846142dc8aad Cr-Commit-Position: refs/heads/master@{#38775}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M src/objects.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
jochen (gone - plz use gerrit)
4 years, 4 months ago (2016-08-22 10:03:13 UTC) #1
Jakob Kummerow
lgtm
4 years, 4 months ago (2016-08-22 10:30:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2265903002/1
4 years, 4 months ago (2016-08-22 10:41:15 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-22 10:43:14 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d181e6e1e6f95ee9c8005a2ad0fc846142dc8aad Cr-Commit-Position: refs/heads/master@{#38775}
4 years, 4 months ago (2016-08-22 10:43:27 UTC) #11
jochen (gone - plz use gerrit)
4 years, 3 months ago (2016-08-26 07:31:57 UTC) #12
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2282663002/ by jochen@chromium.org.

The reason for reverting is: found the culprit.

Powered by Google App Engine
This is Rietveld 408576698