Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Unified Diff: src/objects.cc

Issue 2265903002: Add debug code to catch faulty interceptor (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index 7a8664cfd6cbdfb4b5f854b4c5f6bbc6dddfd3f4..286e8e0d33d2622433e06b5582cf3e1c17fe5716 100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -4576,6 +4576,13 @@ Maybe<bool> Object::SetPropertyInternal(LookupIterator* it,
if (result.IsNothing() || result.FromJust()) return result;
// Interceptor modified the store target but failed to set the
// property.
+ // TODO(jochen): Remove after we've identified the faulty interceptor.
+ if (!store_target_map.is_null() &&
+ *store_target_map != it->GetStoreTarget()->map()) {
+ it->isolate()->PushStackTraceAndDie(
+ 0xabababaa, v8::ToCData<void*>(it->GetInterceptor()->setter()),
+ nullptr, 0xabababab);
+ }
Utils::ApiCheck(store_target_map.is_null() ||
*store_target_map == it->GetStoreTarget()->map(),
it->IsElement() ? "v8::IndexedPropertySetterCallback"
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698