third_party/WebKit/Source/bindings/scripts/v8_interface.py - Issue 2265873003: binding: Moves hasPendingActivity from ActiveScriptWrappable to ScriptWrappable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/scripts/v8_interface.py

Issue 2265873003: binding: Moves hasPendingActivity from ActiveScriptWrappable to ScriptWrappable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed review comments. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp ('K') | « third_party/WebKit/Source/bindings/core/v8/WrapperTypeInfo.cpp ('k') | third_party/WebKit/Source/bindings/templates/interface.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/scripts/v8_interface.py

diff --git a/third_party/WebKit/Source/bindings/scripts/v8_interface.py b/third_party/WebKit/Source/bindings/scripts/v8_interface.py

index be83d4786e55c3d8d073c54bf60da562e6ddcdf2..eb9a20ef4d88e65e9e6e6737bc644586f45ceef8 100644

--- a/third_party/WebKit/Source/bindings/scripts/v8_interface.py

+++ b/third_party/WebKit/Source/bindings/scripts/v8_interface.py

@@ -216,6 +216,11 @@ def interface_context(interface):

wrapper_class_id = ('NodeClassId' if inherits_interface(interface.name, 'Node') else 'ObjectClassId')

+ # [ActiveScriptWrappable] must be accompanied with [DependentLifetime].

+ if active_scriptwrappable and not is_dependent_lifetime:

+ raise Exception('[ActiveScriptWrappable] interface must also specify '

+ '[DependentLifetime]: %s' % interface.name)

v8_class_name = v8_utilities.v8_class_name(interface)

cpp_class_name = cpp_name(interface)

cpp_class_name_or_partial = cpp_name_or_partial(interface)