third_party/WebKit/Source/bindings/core/v8/WrapperTypeInfo.cpp - Issue 2265873003: binding: Moves hasPendingActivity from ActiveScriptWrappable to ScriptWrappable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/WrapperTypeInfo.cpp

Issue 2265873003: binding: Moves hasPendingActivity from ActiveScriptWrappable to ScriptWrappable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed review comments. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp ('K') | « third_party/WebKit/Source/bindings/core/v8/WrapperTypeInfo.h ('k') | third_party/WebKit/Source/bindings/scripts/v8_interface.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/WrapperTypeInfo.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/WrapperTypeInfo.cpp b/third_party/WebKit/Source/bindings/core/v8/WrapperTypeInfo.cpp

index 055858d62dff8fd4ed0f7cea9a6de4ff1bb0e64e..3c9e3da3fbdef34fa0c7f144eb3b4a7bb610a400 100644

--- a/third_party/WebKit/Source/bindings/core/v8/WrapperTypeInfo.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/WrapperTypeInfo.cpp

@@ -13,7 +13,7 @@ static_assert(offsetof(struct WrapperTypeInfo, ginEmbedder) == offsetof(struct g

EventTarget* WrapperTypeInfo::toEventTarget(v8::Local<v8::Object> object) const

{

if (eventTargetInheritance == NotInheritFromEventTarget)

- return 0;

+ return nullptr;

return static_cast<EventTarget*>(toScriptWrappable(object));

}