third_party/WebKit/Source/modules/payments/PaymentRequest.h - Issue 2265873003: binding: Moves hasPendingActivity from ActiveScriptWrappable to ScriptWrappable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/payments/PaymentRequest.h

Issue 2265873003: binding: Moves hasPendingActivity from ActiveScriptWrappable to ScriptWrappable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed review comments. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/notifications/Notification.h ('k') | third_party/WebKit/Source/modules/payments/PaymentRequest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/payments/PaymentRequest.h

diff --git a/third_party/WebKit/Source/modules/payments/PaymentRequest.h b/third_party/WebKit/Source/modules/payments/PaymentRequest.h

index 3290d3e2fd872d2fb6d19bc061d020ee6a6770c3..e3f9a9102ff42c81de7f0e0ee6b87e03b86c8652 100644

--- a/third_party/WebKit/Source/modules/payments/PaymentRequest.h

+++ b/third_party/WebKit/Source/modules/payments/PaymentRequest.h

@@ -60,6 +60,9 @@ public:

DEFINE_ATTRIBUTE_EVENT_LISTENER(shippingaddresschange);

DEFINE_ATTRIBUTE_EVENT_LISTENER(shippingoptionchange);

+ // ScriptWrappable:

+ bool hasPendingActivity() const override;

// EventTargetWithInlineData:

const AtomicString& interfaceName() const override;

ExecutionContext* getExecutionContext() const override;

@@ -81,9 +84,6 @@ private:

// LifecycleObserver:

void contextDestroyed() override;

- // ActiveScriptWrappable:

- bool hasPendingActivity() const override;

// mojom::blink::PaymentRequestClient:

void OnShippingAddressChange(mojom::blink::PaymentAddressPtr) override;

void OnShippingOptionChange(const String& shippingOptionId) override;