third_party/WebKit/Source/modules/payments/PaymentRequest.cpp - Issue 2265873003: binding: Moves hasPendingActivity from ActiveScriptWrappable to ScriptWrappable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/payments/PaymentRequest.cpp

Issue 2265873003: binding: Moves hasPendingActivity from ActiveScriptWrappable to ScriptWrappable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed review comments. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/payments/PaymentRequest.h ('k') | third_party/WebKit/Source/modules/peerconnection/RTCDataChannel.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/payments/PaymentRequest.cpp

diff --git a/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp b/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp

index 22f3dc1edbf4c0fd0b5f64f94ebbbf0e28e4627f..cfcf877aab640b5a3a287983089fa29aaff41592 100644

--- a/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp

+++ b/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp

@@ -408,6 +408,11 @@ ScriptPromise PaymentRequest::abort(ScriptState* scriptState)

return m_abortResolver->promise();

}

+bool PaymentRequest::hasPendingActivity() const

+ return m_showResolver || m_completeResolver;

const AtomicString& PaymentRequest::interfaceName() const

{

return EventTargetNames::PaymentRequest;

@@ -528,11 +533,6 @@ void PaymentRequest::contextDestroyed()

clearResolversAndCloseMojoConnection();

}

-bool PaymentRequest::hasPendingActivity() const

- return m_showResolver || m_completeResolver;

void PaymentRequest::OnShippingAddressChange(mojom::blink::PaymentAddressPtr address)

{

DCHECK(m_showResolver);