third_party/WebKit/Source/bindings/core/v8/ActiveScriptWrappable.cpp - Issue 2265873003: binding: Moves hasPendingActivity from ActiveScriptWrappable to ScriptWrappable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ActiveScriptWrappable.cpp

Issue 2265873003: binding: Moves hasPendingActivity from ActiveScriptWrappable to ScriptWrappable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed review comments. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/ActiveScriptWrappable.h ('k') | third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/ActiveScriptWrappable.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/ActiveScriptWrappable.cpp b/third_party/WebKit/Source/bindings/core/v8/ActiveScriptWrappable.cpp

index 16ac4fc65b0cbfb50838f4fc8a92975b841f00c7..d4a05ccf526ca73fae4c4bb796fc67acb2e6c27e 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ActiveScriptWrappable.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/ActiveScriptWrappable.cpp

@@ -28,11 +28,11 @@ void ActiveScriptWrappable::traceActiveScriptWrappables(v8::Isolate* isolate, Sc

}

for (auto activeWrappable : *activeScriptWrappables) {

- if (!activeWrappable->hasPendingActivity()) {

+ auto scriptWrappable = activeWrappable->toScriptWrappable();

+ if (!scriptWrappable->hasPendingActivity()) {

continue;

}

- auto scriptWrappable = activeWrappable->toScriptWrappable();

auto wrapperTypeInfo = const_cast<WrapperTypeInfo*>(scriptWrappable->wrapperTypeInfo());

visitor->RegisterV8Reference(std::make_pair(wrapperTypeInfo, scriptWrappable));

}