Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Side by Side Diff: third_party/WebKit/Source/bindings/core/v8/ActiveScriptWrappable.cpp

Issue 2265873003: binding: Moves hasPendingActivity from ActiveScriptWrappable to ScriptWrappable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed review comments. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "bindings/core/v8/ActiveScriptWrappable.h" 5 #include "bindings/core/v8/ActiveScriptWrappable.h"
6 6
7 #include "bindings/core/v8/ScriptWrappable.h" 7 #include "bindings/core/v8/ScriptWrappable.h"
8 #include "bindings/core/v8/ScriptWrappableVisitor.h" 8 #include "bindings/core/v8/ScriptWrappableVisitor.h"
9 #include "bindings/core/v8/V8PerIsolateData.h" 9 #include "bindings/core/v8/V8PerIsolateData.h"
10 10
(...skipping 10 matching lines...) Expand all
21 21
22 void ActiveScriptWrappable::traceActiveScriptWrappables(v8::Isolate* isolate, Sc riptWrappableVisitor* visitor) 22 void ActiveScriptWrappable::traceActiveScriptWrappables(v8::Isolate* isolate, Sc riptWrappableVisitor* visitor)
23 { 23 {
24 V8PerIsolateData* isolateData = V8PerIsolateData::from(isolate); 24 V8PerIsolateData* isolateData = V8PerIsolateData::from(isolate);
25 auto activeScriptWrappables = isolateData->activeScriptWrappables(); 25 auto activeScriptWrappables = isolateData->activeScriptWrappables();
26 if (!activeScriptWrappables) { 26 if (!activeScriptWrappables) {
27 return; 27 return;
28 } 28 }
29 29
30 for (auto activeWrappable : *activeScriptWrappables) { 30 for (auto activeWrappable : *activeScriptWrappables) {
31 if (!activeWrappable->hasPendingActivity()) { 31 auto scriptWrappable = activeWrappable->toScriptWrappable();
32 if (!scriptWrappable->hasPendingActivity()) {
32 continue; 33 continue;
33 } 34 }
34 35
35 auto scriptWrappable = activeWrappable->toScriptWrappable();
36 auto wrapperTypeInfo = const_cast<WrapperTypeInfo*>(scriptWrappable->wra pperTypeInfo()); 36 auto wrapperTypeInfo = const_cast<WrapperTypeInfo*>(scriptWrappable->wra pperTypeInfo());
37 visitor->RegisterV8Reference(std::make_pair(wrapperTypeInfo, scriptWrapp able)); 37 visitor->RegisterV8Reference(std::make_pair(wrapperTypeInfo, scriptWrapp able));
38 } 38 }
39 } 39 }
40 40
41 } // namespace blink 41 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698