Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 2265803002: Simplify the gradient color stop optimizer (Closed)

Created:
4 years, 4 months ago by f(malita)
Modified:
4 years, 4 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Simplify the gradient color stop optimizer We're just discarding the leftmost/rightmost stops -- this can be achieved by simply adjusting the start offset and count. R=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2265803002 Committed: https://skia.googlesource.com/skia/+/582a6564f36c90cc8e3e8c7338578023449b096c

Patch Set 1 #

Patch Set 2 : the test goes in separate CL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -11 lines) Patch
M src/effects/gradients/SkGradientShader.cpp View 3 chunks +5 lines, -11 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
f(malita)
4 years, 4 months ago (2016-08-21 18:25:59 UTC) #2
reed1
lgtm
4 years, 4 months ago (2016-08-22 11:55:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2265803002/20001
4 years, 4 months ago (2016-08-22 13:28:09 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 13:29:01 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/582a6564f36c90cc8e3e8c7338578023449b096c

Powered by Google App Engine
This is Rietveld 408576698