Simplify the gradient color stop optimizer

src/effects/gradients/SkGradientShader.cpp

 /*
  * Copyright 2006 The Android Open Source Project
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "Sk4fLinearGradient.h"
 #include "SkGradientShaderPriv.h"
 #include "SkLinearGradient.h"
@@ skipping 768 matching lines @@
             }
 
             if (SkScalarNearlyEqual(pos[0], 0.0f) &&
                 SkScalarNearlyEqual(pos[1], 0.0f) &&
                 SkScalarNearlyEqual(pos[2], 1.0f)) {
 
                 if (SkShader::kRepeat_TileMode == mode ||
                     SkShader::kMirror_TileMode == mode ||
                     colors[0] == colors[1]) {
 
-                    fColorStorage[0] = colors[1];
-                    fColorStorage[1] = colors[2];
-                    fPosStorage[0] = 0.0f;
-                    fPosStorage[1] = 1.0f;
-
-                    fColors = fColorStorage;
-                    fPos    = fPosStorage;
-                    fCount  = 2;
+                    // Ignore the leftmost color/pos.
+                    fColors += 1;
+                    fPos    += 1;
+                    fCount   = 2;
                 }
             } else if (SkScalarNearlyEqual(pos[0], 0.0f) &&
                        SkScalarNearlyEqual(pos[1], 1.0f) &&
                        SkScalarNearlyEqual(pos[2], 1.0f)) {
 
                 if (SkShader::kRepeat_TileMode == mode ||
                     SkShader::kMirror_TileMode == mode ||
                     colors[1] == colors[2]) {
 
+                    // Ignore the rightmost color/pos.
                     fCount  = 2;
                 }
             }
     }
 
     const SkColor*  fColors;
     const SkScalar* fPos;
     int             fCount;
-
-    SkColor         fColorStorage[2];
-    SkScalar        fPosStorage[2];
 };
 
 sk_sp<SkShader> SkGradientShader::MakeLinear(const SkPoint pts[2],
                                              const SkColor colors[],
                                              const SkScalar pos[], int colorCount,
                                              SkShader::TileMode mode,
                                              uint32_t flags,
                                              const SkMatrix* localMatrix) {
     if (!pts || !SkScalarIsFinite((pts[1] - pts[0]).length())) {
         return nullptr;
@@ skipping 664 matching lines @@
             (*stops)[i] = stop;
             stop = i < outColors - 1 ? stop + random->nextUScalar1() * (1.f - stop) : 1.f;
         }
     }
     *tm = static_cast<SkShader::TileMode>(random->nextULessThan(SkShader::kTileModeCount));
 
     return outColors;
 }
 
 #endif