Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2265663002: [Extensions] *Really* generate all schema resources (Closed)

Created:
4 years, 4 months ago by Devlin
Modified:
4 years, 4 months ago
Reviewers:
lazyboy
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] *Really* generate all schema resources https://codereview.chromium.org/2257003002 missed a few. Gotta catch 'em all! BUG=638758 Committed: https://crrev.com/f11d58a2d412c518a75bd9b8250aff271dcef24d Cr-Commit-Position: refs/heads/master@{#413298}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -35 lines) Patch
M extensions/common/api/declarative_web_request.json View 22 chunks +139 lines, -26 lines 0 comments Download
M extensions/common/api/schemas.gni View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/common/api/schemas.gypi View 1 chunk +4 lines, -0 lines 0 comments Download
M extensions/common/extension_api.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M extensions/extensions_resources.grd View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Devlin
D'oh! Missed a few.
4 years, 4 months ago (2016-08-19 22:17:14 UTC) #4
lazyboy
lgtm.
4 years, 4 months ago (2016-08-19 22:48:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2265663002/1
4 years, 4 months ago (2016-08-20 00:42:38 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-20 00:48:11 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-20 00:51:05 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f11d58a2d412c518a75bd9b8250aff271dcef24d
Cr-Commit-Position: refs/heads/master@{#413298}

Powered by Google App Engine
This is Rietveld 408576698