[Extensions] Generate all schema resources

[Extensions] Generate all schema resources

Some schema resources weren't being generated (presumably because
resource generation was previously linked to function registration).
However, generated schema resources are a lot better, because they strip
out comments and whitespace, making parsing them into JSON significantly
faster.

Generate all schema resources, and remove the grit files containing the
JSON.

Note: because inline enums are disallowed (see crbug.com/472279), some
schemas had to be updated. Since they weren't previously compiled, this
wasn't caught.

This also eliminates a 100k resource file (extensions_api_resources.pak).

BUG=638758
Committed: https://crrev.com/2d823a6736d032aa3215d1ee0994031bb0245e5b
Cr-Commit-Position: refs/heads/master@{#413200}

[Devlin, 2016-08-18 01:09:23]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-18 01:10:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Devlin, 2016-08-18 01:16:44]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-18 01:17:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 01:28:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-18 01:28:45]

Dry run: Exceeded global retry quota

[Devlin, 2016-08-18 02:09:49]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-18 02:10:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 03:05:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-18 03:05:41]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Devlin, 2016-08-18 15:09:50]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-18 15:10:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 15:13:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-18 15:13:17]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Devlin, 2016-08-18 16:59:38]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-18 17:00:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 17:58:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-18 17:58:38]

Dry run: Try jobs failed on following builders:
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Devlin, 2016-08-18 19:49:50]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-18 19:50:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Devlin, 2016-08-18 20:49:12]

Patchset #1 (id:1) has been deleted

[Devlin, 2016-08-18 20:50:11]

Patchset #1 (id:20001) has been deleted

[Devlin, 2016-08-18 20:52:18]

Patchset #1 (id:40001) has been deleted

[Devlin, 2016-08-18 20:52:57]

Patchset #1 (id:60001) has been deleted

[Devlin, 2016-08-18 20:53:05]

Patchset #1 (id:80001) has been deleted

[commit-bot: I haz the power, 2016-08-18 20:59:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-18 20:59:38]

Dry run: This issue passed the CQ dry run.

[Devlin, 2016-08-18 22:17:01]

Description was changed from

==========
woot

BUG=
==========

to

==========
[Extensions] Generate all schema resources

Some schema resources weren't being generated (presumably because
resource generation was previously linked to function registration).
However, generated schema resources are a lot better, because they strip
out comments and whitespace, making parsing them into JSON significantly
faster.

Generate all schema resources, and remove the grit files containing the
JSON.

Note: because inline enums are disallowed (see crbug.com/472279), some
schemas had to be updated. Since they weren't previously compiled, this
wasn't caught.

This also eliminates a 100k resource file (extensions_api_resources.pak).

BUG=638758
==========

[Devlin, 2016-08-18 22:21:27]

rdevlin.cronin@chromium.org changed reviewers:
+ lazyboy@chromium.org, thestig@chromium.org

[Devlin, 2016-08-18 22:21:27]

Istiaque, mind taking a look?
Lei, can you look at the non-extensions files?

https://codereview.chromium.org/2257003002/diff/100001/chrome/common/extensio...
File chrome/common/extensions/chrome_extensions_client.cc (left):

https://codereview.chromium.org/2257003002/diff/100001/chrome/common/extensio...
chrome/common/extensions/chrome_extensions_client.cc:257: ExtensionAPI* api)
const {
I think we can remove this now - I'll do that in a followup.

[Lei Zhang, 2016-08-18 22:36:01]

lgtm !

https://codereview.chromium.org/2257003002/diff/100001/tools/gritsettings/res...
File tools/gritsettings/resource_ids (left):

https://codereview.chromium.org/2257003002/diff/100001/tools/gritsettings/res...
tools/gritsettings/resource_ids:225:
"chrome/common/extensions_api_resources.grd": {
Thank you for freeing up some precious ID space. :)

[Devlin, 2016-08-18 23:32:50]

rdevlin.cronin@chromium.org changed reviewers:
+ dpranke@chromium.org

[Devlin, 2016-08-18 23:32:50]

+also dpranke for //build/.

[Dirk Pranke, 2016-08-18 23:40:16]

lgtm

[lazyboy, 2016-08-19 02:03:30]

extensions stuff lgtm.

https://codereview.chromium.org/2257003002/diff/100001/build/json_schema_api.gni
File build/json_schema_api.gni (right):

https://codereview.chromium.org/2257003002/diff/100001/build/json_schema_api....
build/json_schema_api.gni:142: uncompiled_bundle_schema_sources = []
Do you need to describe what "uncompiled_bundle_schema_sources" mean in the
comment header in this file?

[Devlin, 2016-08-19 16:16:13]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-19 16:16:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Devlin, 2016-08-19 17:55:30]

https://codereview.chromium.org/2257003002/diff/100001/build/json_schema_api.gni
File build/json_schema_api.gni (right):

https://codereview.chromium.org/2257003002/diff/100001/build/json_schema_api....
build/json_schema_api.gni:142: uncompiled_bundle_schema_sources = []
On 2016/08/19 02:03:30, lazyboy wrote:
> Do you need to describe what "uncompiled_bundle_schema_sources" mean in the
> comment header in this file?

Done.

[Devlin, 2016-08-19 17:55:37]

The CQ bit was unchecked by rdevlin.cronin@chromium.org

[Devlin, 2016-08-19 17:55:38]

The CQ bit was checked by rdevlin.cronin@chromium.org

[Devlin, 2016-08-19 17:55:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
thestig@chromium.org, dpranke@chromium.org, lazyboy@chromium.org
Link to the patchset: https://codereview.chromium.org/2257003002/#ps120001
(title: "Add comment")

[commit-bot: I haz the power, 2016-08-19 17:55:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 18:59:35]

Description was changed from

==========
[Extensions] Generate all schema resources

Some schema resources weren't being generated (presumably because
resource generation was previously linked to function registration).
However, generated schema resources are a lot better, because they strip
out comments and whitespace, making parsing them into JSON significantly
faster.

Generate all schema resources, and remove the grit files containing the
JSON.

Note: because inline enums are disallowed (see crbug.com/472279), some
schemas had to be updated. Since they weren't previously compiled, this
wasn't caught.

This also eliminates a 100k resource file (extensions_api_resources.pak).

BUG=638758
==========

to

==========
[Extensions] Generate all schema resources

Some schema resources weren't being generated (presumably because
resource generation was previously linked to function registration).
However, generated schema resources are a lot better, because they strip
out comments and whitespace, making parsing them into JSON significantly
faster.

Generate all schema resources, and remove the grit files containing the
JSON.

Note: because inline enums are disallowed (see crbug.com/472279), some
schemas had to be updated. Since they weren't previously compiled, this
wasn't caught.

This also eliminates a 100k resource file (extensions_api_resources.pak).

BUG=638758
==========

[commit-bot: I haz the power, 2016-08-19 18:59:36]

Committed patchset #2 (id:120001)

[commit-bot: I haz the power, 2016-08-19 19:04:45]

Description was changed from

==========
[Extensions] Generate all schema resources

Some schema resources weren't being generated (presumably because
resource generation was previously linked to function registration).
However, generated schema resources are a lot better, because they strip
out comments and whitespace, making parsing them into JSON significantly
faster.

Generate all schema resources, and remove the grit files containing the
JSON.

Note: because inline enums are disallowed (see crbug.com/472279), some
schemas had to be updated. Since they weren't previously compiled, this
wasn't caught.

This also eliminates a 100k resource file (extensions_api_resources.pak).

BUG=638758
==========

to

==========
[Extensions] Generate all schema resources

Some schema resources weren't being generated (presumably because
resource generation was previously linked to function registration).
However, generated schema resources are a lot better, because they strip
out comments and whitespace, making parsing them into JSON significantly
faster.

Generate all schema resources, and remove the grit files containing the
JSON.

Note: because inline enums are disallowed (see crbug.com/472279), some
schemas had to be updated. Since they weren't previously compiled, this
wasn't caught.

This also eliminates a 100k resource file (extensions_api_resources.pak).

BUG=638758

Committed: https://crrev.com/2d823a6736d032aa3215d1ee0994031bb0245e5b
Cr-Commit-Position: refs/heads/master@{#413200}
==========

[commit-bot: I haz the power, 2016-08-19 19:04:46]

Patchset 2 (id:??) landed as
https://crrev.com/2d823a6736d032aa3215d1ee0994031bb0245e5b
Cr-Commit-Position: refs/heads/master@{#413200}