[Telemetry] Explictly intialize & clean up network_controller

[Telemetry] Explictly initialize & clean up network_controller

It turns out that implicitly initialize network controller 
whenever platform instance is created is a bad idea. Although
it's more ergonomic, it hides the responsiblity of call sites 
to clean up the network_controller (shutting down 
ts_proxy_server).

This CL makes remove implicitly initializing network_controller
and requires call sites to be explicit about doing so & clean
it up when they finish using network_controller.

BUG=catapult:#2584
TBR=sullivan@chromium.org, pmeenan@chromium.org

Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/30ce231266c6fb6147bb6df7c56a7eb75c23fccf

[nednguyen, 2016-08-20 01:00:49]

The CQ bit was checked by nednguyen@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-20 01:00:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-20 01:16:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-20 01:16:30]

Dry run: Try jobs failed on following builders:
  Catapult Mac Tryserver on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Ma...)

[nednguyen, 2016-08-20 01:34:07]

Description was changed from

==========
[Telemetry] Explictly intialize & clean up network_controller

BUG=catapult:#2584
==========

to

==========
[Telemetry] Explictly initialize & clean up network_controller

It turns out that implicitly initialize network controller 
whenever platform instance is created is a bad idea. Although
it's more ergonomic, it hides the responsiblity of call sites 
to clean up the network_controller (shutting down 
ts_proxy_server).

This CL makes remove implicitly initializing network_controller
and requires call sites to be explicit about doing so & clean
it up when they finish using network_controller.

BUG=catapult:#2584
TBR=sullivan@chromium.org
==========

[nednguyen, 2016-08-20 01:34:24]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2016-08-20 01:34:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nednguyen, 2016-08-20 01:35:45]

Description was changed from

==========
[Telemetry] Explictly initialize & clean up network_controller

It turns out that implicitly initialize network controller 
whenever platform instance is created is a bad idea. Although
it's more ergonomic, it hides the responsiblity of call sites 
to clean up the network_controller (shutting down 
ts_proxy_server).

This CL makes remove implicitly initializing network_controller
and requires call sites to be explicit about doing so & clean
it up when they finish using network_controller.

BUG=catapult:#2584
TBR=sullivan@chromium.org
==========

to

==========
[Telemetry] Explictly initialize & clean up network_controller

It turns out that implicitly initialize network controller 
whenever platform instance is created is a bad idea. Although
it's more ergonomic, it hides the responsiblity of call sites 
to clean up the network_controller (shutting down 
ts_proxy_server).

This CL makes remove implicitly initializing network_controller
and requires call sites to be explicit about doing so & clean
it up when they finish using network_controller.

BUG=catapult:#2584
TBR=sullivan@chromium.org, pmeenan@chromium.org
==========

[commit-bot: I haz the power, 2016-08-20 01:55:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-20 01:55:45]

Try jobs failed on following builders:
  Catapult Android Tryserver on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20An...)

[nednguyen, 2016-08-20 02:05:03]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2016-08-20 02:05:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nednguyen, 2016-08-20 02:22:04]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2016-08-20 02:22:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nednguyen, 2016-08-20 02:43:51]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2016-08-20 02:44:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-20 03:35:50]

Description was changed from

==========
[Telemetry] Explictly initialize & clean up network_controller

It turns out that implicitly initialize network controller 
whenever platform instance is created is a bad idea. Although
it's more ergonomic, it hides the responsiblity of call sites 
to clean up the network_controller (shutting down 
ts_proxy_server).

This CL makes remove implicitly initializing network_controller
and requires call sites to be explicit about doing so & clean
it up when they finish using network_controller.

BUG=catapult:#2584
TBR=sullivan@chromium.org, pmeenan@chromium.org
==========

to

==========
[Telemetry] Explictly initialize & clean up network_controller

It turns out that implicitly initialize network controller 
whenever platform instance is created is a bad idea. Although
it's more ergonomic, it hides the responsiblity of call sites 
to clean up the network_controller (shutting down 
ts_proxy_server).

This CL makes remove implicitly initializing network_controller
and requires call sites to be explicit about doing so & clean
it up when they finish using network_controller.

BUG=catapult:#2584
TBR=sullivan@chromium.org, pmeenan@chromium.org

Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2016-08-20 03:35:51]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...