telemetry/telemetry/testing/browser_test_case.py - Issue 2265593003: [Telemetry] Explictly intialize & clean up network_controller

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: telemetry/telemetry/testing/browser_test_case.py

Issue 2265593003: [Telemetry] Explictly intialize & clean up network_controller (Closed) Base URL: https://github.com/catapult-project/catapult.git@master

Patch Set: Fix testRestoreBrowserWithMultipleTabs for real part 2 Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « telemetry/telemetry/internal/browser/extension_unittest.py ('k') | telemetry/telemetry/testing/serially_executed_browser_test_case.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: telemetry/telemetry/testing/browser_test_case.py

diff --git a/telemetry/telemetry/testing/browser_test_case.py b/telemetry/telemetry/testing/browser_test_case.py

index ea4d449aa9446800357e4d1dea11e618454ea049..956e5d85e8a8b8994fabde0f699e0658f50f3522 100644

--- a/telemetry/telemetry/testing/browser_test_case.py

+++ b/telemetry/telemetry/testing/browser_test_case.py

@@ -101,6 +101,7 @@ class BrowserTestCase(unittest.TestCase):

def tearDownClass(cls):

if cls._platform:

cls._platform.StopAllLocalServers()

+ cls._platform.network_controller.Close()

@classmethod

def CustomizeBrowserOptions(cls, options):