MD Settings: fix metrics reporting unittests on official testers -- take 2

MD Settings: fix metrics reporting unittests on official testers -- take 2

R=dschuyler@chromium.org
BUG=637068
Committed: https://crrev.com/2c9f3ce6a063b05b3a8dc7cc1fa127d44f83d624
Cr-Commit-Position: refs/heads/master@{#414270}

[Dan Beam, 2016-08-19 19:42:37]

Patchset #2 (id:20001) has been deleted

[Dan Beam, 2016-08-19 19:42:41]

Patchset #1 (id:1) has been deleted

[Dan Beam, 2016-08-19 19:42:54]

a little spammy, but let's just see if it works...

[dschuyler, 2016-08-19 21:14:04]

https://codereview.chromium.org/2265553003/diff/40001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/settings/metrics_reporting_handler_unittest.cc
(right):

https://codereview.chromium.org/2265553003/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/settings/metrics_reporting_handler_unittest.cc:68:
base::RunLoop().RunUntilIdle();
imo, this begs for a comment about what
the goal is. Maybe a TODO style comment?

[Dan Beam, 2016-08-24 19:17:56]

https://codereview.chromium.org/2265553003/diff/40001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/settings/metrics_reporting_handler_unittest.cc
(right):

https://codereview.chromium.org/2265553003/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/settings/metrics_reporting_handler_unittest.cc:68:
base::RunLoop().RunUntilIdle();
On 2016/08/19 21:14:04, dschuyler wrote:
> imo, this begs for a comment about what
> the goal is. Maybe a TODO style comment?

Done.

[dschuyler, 2016-08-24 22:14:59]

lgtm

https://codereview.chromium.org/2265553003/diff/60001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/settings/metrics_reporting_handler_unittest.cc
(right):

https://codereview.chromium.org/2265553003/diff/60001/chrome/browser/ui/webui...
chrome/browser/ui/webui/settings/metrics_reporting_handler_unittest.cc:64: //
For crbug.com/637068 which only run on official bots with no try jobs.
I suggest ignoring this optional nit:
but just to be thorough s/run/runs/

[Dan Beam, 2016-08-24 23:21:53]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2016-08-24 23:23:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 02:28:59]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2016-08-25 02:30:39]

Description was changed from

==========
MD Settings: fix metrics reporting unittests on official testers -- take 2

R=dschuyler@chromium.org
BUG=637068
==========

to

==========
MD Settings: fix metrics reporting unittests on official testers -- take 2

R=dschuyler@chromium.org
BUG=637068

Committed: https://crrev.com/2c9f3ce6a063b05b3a8dc7cc1fa127d44f83d624
Cr-Commit-Position: refs/heads/master@{#414270}
==========

[commit-bot: I haz the power, 2016-08-25 02:30:40]

Patchset 2 (id:??) landed as
https://crrev.com/2c9f3ce6a063b05b3a8dc7cc1fa127d44f83d624
Cr-Commit-Position: refs/heads/master@{#414270}