Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Unified Diff: chrome/browser/ui/webui/settings/metrics_reporting_handler_unittest.cc

Issue 2265553003: MD Settings: fix metrics reporting unittests on official testers -- take 2 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: todo Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/settings/metrics_reporting_handler_unittest.cc
diff --git a/chrome/browser/ui/webui/settings/metrics_reporting_handler_unittest.cc b/chrome/browser/ui/webui/settings/metrics_reporting_handler_unittest.cc
index 038cd6a33b55ed70f9d5707809502d4a63209099..6c3f9c4329a91128fb37d9db9c06b2a70151e2dc 100644
--- a/chrome/browser/ui/webui/settings/metrics_reporting_handler_unittest.cc
+++ b/chrome/browser/ui/webui/settings/metrics_reporting_handler_unittest.cc
@@ -61,7 +61,12 @@ class MetricsReportingHandlerTest : public testing::Test {
}
void TearDown() override {
+ // For crbug.com/637068 which only run on official bots with no try jobs.
dschuyler 2016/08/24 22:14:59 I suggest ignoring this optional nit: but just to
+ base::RunLoop().RunUntilIdle();
handler_.reset();
+ base::RunLoop().RunUntilIdle();
+ local_state_.reset();
+ base::RunLoop().RunUntilIdle();
}
PrefService* local_state() { return local_state_->Get(); }
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698